Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp966674ybb; Wed, 8 Apr 2020 13:32:15 -0700 (PDT) X-Google-Smtp-Source: APiQypKIMEYox0p3EoO8xxrdDPuATwQPiwqSwg3Y+eyQnyBlopz6u0R9pWiYhiHf9fQAo5pE/0wU X-Received: by 2002:aca:ac92:: with SMTP id v140mr3891577oie.67.1586377935028; Wed, 08 Apr 2020 13:32:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586377935; cv=none; d=google.com; s=arc-20160816; b=IM4IrV/Vs1z+RVm9wVrNfUGb4DrYxeFRwQsTtXU7dn+A85mrHXwxgc/gANmw2G4Oro NfX2vGaC9FYgGCK9K9vczurR6Lawy9qEC1Pqaor2UIxr+ZOh/da+qAmeZNCzSARIHb6r G1C/Yq5SoXT/7NdtqDn+t6tNfDkrIpm22Lc8MvVyoSBCoyo6LqMncDhxHaDmLADCfIQz F8u/1vkdTtS/5N4jA3GhXsow0nC5JGKSBydsDchtSVpjQgQ52N2GM+khj3kYi8n5guZk TkOhoEBsu8hQ8o49BVB+079kW9ugP53CH9CqnvqrcO9b6TS0ckLMxwmBBEt8uvH2g15f wxkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=KBiweWQ6rbNbDcMPtdUJ7nhqBub63rFhMdk3Z4LHG2I=; b=XzL506TPzZuDpElITBmBooT1c5pYb+CQKZhbPMuktx0xiU/o3s7QDNHHfZCrKoVUEc v8Ps7/Ep2Jhv+auzGEbiU0SG0N6yFef9svVv/XCPzVveMuDhNXRpRSahqQevXoWap09x Jg8+X5bwEC+YNM760vkESso3/B2NatK3Tr0mHDQCNLVVtvmF+/AX2GhXP71rAisTwe3u xTRDC15mrxVJdT9hoydHMpZPSitSmXQ8MKsXd3/5Emrn0WoW9wuaWRh85/xqHmge5SAl xI0TB/caSUI2eD+T6V247+Ex0UEt8gc1KE0Dv57eJWciktGY66jOeWWfP7Oawr9uyTxO U0yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 30si2826889oth.68.2020.04.08.13.32.03; Wed, 08 Apr 2020 13:32:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729912AbgDHTQs (ORCPT + 99 others); Wed, 8 Apr 2020 15:16:48 -0400 Received: from verein.lst.de ([213.95.11.211]:43787 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728209AbgDHTQr (ORCPT ); Wed, 8 Apr 2020 15:16:47 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B967C68C4E; Wed, 8 Apr 2020 21:16:44 +0200 (CEST) Date: Wed, 8 Apr 2020 21:16:44 +0200 From: Christoph Hellwig To: Grygorii Strashko Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , iommu@lists.linux-foundation.org, Sekhar Nori , linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma-debug: fix displaying of dma allocation type Message-ID: <20200408191644.GA12239@lst.de> References: <20200408184804.30522-1-grygorii.strashko@ti.com> <20200408184958.GA9945@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 08, 2020 at 10:13:55PM +0300, Grygorii Strashko wrote: >>> -static const char *type2name[5] = { "single", "page", >>> +static const char *type2name[5] = { "single", >>> "scather-gather", "coherent", >>> "resource" }; >> >> To make sure this doesn't happen anymore, can you switch to >> named initializers? >> > > Just to clarify. > Do you mean > [dma_debug_coherent] = "coherent", > ? Yes.