Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 08 Apr 2020 12:56:06 -0700 (PDT)
Message-Id: <20200408.125606.1078177957758077983.davem@davemloft.net>
To:     wenhu.wang@vivo.com
Cc:     kuba@kernel.org, bjorn.andersson@linaro.org,
        cjhuang@codeaurora.org, tglx@linutronix.de, arnd@arndb.de,
        hofrat@osadl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@vivo.com
Subject: Re: [PATCH v2] net: qrtr: send msgs from local of same id as
 broadcast
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200408033249.120608-1-wenhu.wang@vivo.com>
References: <20200407132930.109738-1-wenhu.wang@vivo.com>
        <20200408033249.120608-1-wenhu.wang@vivo.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: WANG Wenhu <wenhu.wang@vivo.com>
Date: Tue,  7 Apr 2020 20:32:47 -0700

> -		enqueue_fn = qrtr_bcast_enqueue;
> -		if (addr->sq_port != QRTR_PORT_CTRL) {
> +		if (addr->sq_port != QRTR_PORT_CTRL &&
> +			qrtr_local_nid != QRTR_NODE_BCAST) {

This is still not correct, it should be:

		if (addr->sq_port != QRTR_PORT_CTRL &&
		    qrtr_local_nid != QRTR_NODE_BCAST) {