Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750899AbWB0Jrn (ORCPT ); Mon, 27 Feb 2006 04:47:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750849AbWB0Jrm (ORCPT ); Mon, 27 Feb 2006 04:47:42 -0500 Received: from e6.ny.us.ibm.com ([32.97.182.146]:59085 "EHLO e6.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1750749AbWB0Jrm (ORCPT ); Mon, 27 Feb 2006 04:47:42 -0500 Date: Mon, 27 Feb 2006 15:19:11 +0530 From: Prasanna S Panchamukhi To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S. Miller" , akpm@osdl.org Subject: Re: [PATCH] kprobes: kprobe_mutex is no longer a semaphore Message-ID: <20060227094911.GA6135@in.ibm.com> Reply-To: prasanna@in.ibm.com References: <200602251242.46408.jesper.juhl@gmail.com> <20060227064258.GB19153@in.ibm.com> <9a8748490602270141y67316c66q4be2ce64d9786eb9@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a8748490602270141y67316c66q4be2ce64d9786eb9@mail.gmail.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1839 Lines: 54 On Mon, Feb 27, 2006 at 10:41:40AM +0100, Jesper Juhl wrote: > On 2/27/06, Prasanna S Panchamukhi wrote: > > On Sat, Feb 25, 2006 at 12:42:46PM +0100, Jesper Juhl wrote: > > > > > > kprobe_mutex used to be a semaphore it is now a mutex, so calling down/up on > > > it is wrong, we should be using mutex_lock/mutex_unlock instead. > > > > > > gcc was kind enough to warn about this : > > > arch/i386/kernel/kprobes.c: In function `arch_remove_kprobe': > > > arch/i386/kernel/kprobes.c:135: warning: passing arg 1 of `down' from incompatible pointer type > > > arch/i386/kernel/kprobes.c:137: warning: passing arg 1 of `up' from incompatible pointer type > > > > > > > > > Signed-off-by: Jesper Juhl > > > > > > Looks good, this patch depends on the sem2mutex-kprobes.patch in -mm > > tree. > > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc4/2.6.16-rc4-mm2/broken-out/sem2mutex-kprobes.patch > > > > Acked-by : Prasanna S Panchamukhi > > > > Thank you. > > Are you going to merge it / push it to Andrew or Linus? Yes. > If not I'll just queue it up with some other patches I have lying > around and forward it with those other patches in a week or so. > > Thanks Prasanna > -- > Jesper Juhl > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html > Plain text mails only, please http://www.expita.com/nomime.html -- Prasanna S Panchamukhi Linux Technology Center India Software Labs, IBM Bangalore Email: prasanna@in.ibm.com Ph: 91-80-51776329 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/