Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1003314ybb; Wed, 8 Apr 2020 14:22:45 -0700 (PDT) X-Google-Smtp-Source: APiQypIX3SRlksnQuOOJrC8xlUMv82XKQ6ORnK/NjDbb6FuoK6+eTokBhEFpQDrcwl1A14sRLlKH X-Received: by 2002:aca:f183:: with SMTP id p125mr4112200oih.74.1586380965705; Wed, 08 Apr 2020 14:22:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586380965; cv=none; d=google.com; s=arc-20160816; b=rotZfF1hHI71zFVbCgrFQpMPnllSeWMRHvh1lc23VMHg2D4zVTDLWO6I+sfG4HfbS2 pqk/5Fj0mr0aUcdX1Upeih51ASFY9BFl4hOSjAxtdoKHFKhcDD4G5+jQI5xDjFzQMrnW KLchVddugmF7vAm4GGAcJHnXkx1vl18sQC75vowKnjhunRZltCHbtcHea+TOWPNO4ncj OOPqRcfAqhGmVfX8XH2WGsDjj16ePusxYuuB1AqDzdx+dLWXO+KJAty61rTc/GyhQwKH aJYr/8JpwHxnap6NxlxzVHbdHjP34Lp4ltNQN0Z9KcoQ6zw4cZ/7oO09T0luhe27zrjL ggmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:dkim-signature; bh=FYJHOBunNAkqZBTOKzs2lAXiPeKDnuhxIxE82v7LAzo=; b=cSMz6VadpR5fXmCJzw1KmOAMg/9mXFH1/b4M8Q2hucr1CFE/IhKg0lVPVL8sL0adO4 nLesDB1lQ+DjVKSLGHZkwb+tJxNTPQZA5rh4YnNs1+ey0RWwf/2dcK6vMT82ktJpLGb0 5jUAW2tlpcR4GUoXSP0UdvTpE+sTkYCLT964hhnH3CsSHvblJsK9kut0nP3uqqqEX/Em vmhRRhIVql562CCtb9/Zmc91dQRtuiWzZmkStCuhoESVvUDb8rJF/fIkOIyQcvPfbMO4 qduUl4Sa3viQDcG6WH6NbVbEP4tVhFM3RwUHE0lf9VWCIdmLyaWJnGpyf9hvSo78btpq rxsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b="It9/bv1u"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y4si2986826ooh.53.2020.04.08.14.22.33; Wed, 08 Apr 2020 14:22:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b="It9/bv1u"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730622AbgDHSNO (ORCPT + 99 others); Wed, 8 Apr 2020 14:13:14 -0400 Received: from forwardcorp1j.mail.yandex.net ([5.45.199.163]:54164 "EHLO forwardcorp1j.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730618AbgDHSNO (ORCPT ); Wed, 8 Apr 2020 14:13:14 -0400 Received: from mxbackcorp1j.mail.yandex.net (mxbackcorp1j.mail.yandex.net [IPv6:2a02:6b8:0:1619::162]) by forwardcorp1j.mail.yandex.net (Yandex) with ESMTP id C9C112E153E; Wed, 8 Apr 2020 21:13:10 +0300 (MSK) Received: from iva8-88b7aa9dc799.qloud-c.yandex.net (iva8-88b7aa9dc799.qloud-c.yandex.net [2a02:6b8:c0c:77a0:0:640:88b7:aa9d]) by mxbackcorp1j.mail.yandex.net (mxbackcorp/Yandex) with ESMTP id weMpEu5e15-DAMawS8n; Wed, 08 Apr 2020 21:13:10 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1586369590; bh=FYJHOBunNAkqZBTOKzs2lAXiPeKDnuhxIxE82v7LAzo=; h=Message-ID:Date:To:From:Subject:Cc; b=It9/bv1ubfflgvX5xoyviU5pKz4zW2+fxSLxd7eUAy9fTD/K1nTyLFeFAEFYd/YGX IpaM2nYKwWxyxeSPW9mLxL3bLvMgYnQWU6Sl4pAa82wrLFahJykjYUhbI9kAlReLos gBX4WgF5QlqS+bYqnA4E91o0/krVDYgM5E44Gq5g= Authentication-Results: mxbackcorp1j.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Received: from unknown (unknown [2a02:6b8:b080:8808::1:4]) by iva8-88b7aa9dc799.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id 5CWE3zneGl-DAWOe8xk; Wed, 08 Apr 2020 21:13:10 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) Subject: [PATCH] tracing/x86: fix trace event registration for syscalls without arguments From: Konstantin Khlebnikov To: Brian Gerst , linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Dominik Brodowski , Andy Lutomirski Date: Wed, 08 Apr 2020 21:13:10 +0300 Message-ID: <158636958997.7900.16485049455470033557.stgit@buzz> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Syscalls without arguments now has no ABI subs, instead of that macro SYSCALL_DEFINE0() defines __abi_sys_name as aliase to __do_sys_name. As a result in find_syscall_meta() kallsyms_lookup() returns "__do_sys_name" which does not match with declared trace event. Also see commit 1c758a2202a6 ("tracing/x86: Update syscall trace events to handle new prefixed syscall func names") Fixes: d2b5de495ee9 ("x86/entry: Refactor SYSCALL_DEFINE0 macros") Signed-off-by: Konstantin Khlebnikov --- arch/x86/include/asm/ftrace.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h index 85be2f506272..70b96cae5b42 100644 --- a/arch/x86/include/asm/ftrace.h +++ b/arch/x86/include/asm/ftrace.h @@ -61,11 +61,12 @@ static inline bool arch_syscall_match_sym_name(const char *sym, const char *name { /* * Compare the symbol name with the system call name. Skip the - * "__x64_sys", "__ia32_sys" or simple "sys" prefix. + * "__x64_sys", "__ia32_sys", "__do_sys" or simple "sys" prefix. */ return !strcmp(sym + 3, name + 3) || (!strncmp(sym, "__x64_", 6) && !strcmp(sym + 9, name + 3)) || - (!strncmp(sym, "__ia32_", 7) && !strcmp(sym + 10, name + 3)); + (!strncmp(sym, "__ia32_", 7) && !strcmp(sym + 10, name + 3)) || + (!strncmp(sym, "__do_sys", 8) && !strcmp(sym + 8, name + 3)); } #ifndef COMPILE_OFFSETS