Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1036099ybb; Wed, 8 Apr 2020 15:09:24 -0700 (PDT) X-Google-Smtp-Source: APiQypLHfjyuxlcdyXE/VFr7drriAc71NUNYnDH6X6lbQ79UJTPsXkMfgF8bjkxG8DO/EdaALI5g X-Received: by 2002:a9d:5b4:: with SMTP id 49mr279625otd.210.1586383764198; Wed, 08 Apr 2020 15:09:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586383764; cv=none; d=google.com; s=arc-20160816; b=LgAPxMqKL1S6gkAnJD18i7eGzzs9hmuu4J1vOVQ71eoDaDVX3YCkKAjrHeOsD1zgPr 6pejD8035EX/egbdSQSryF9lzg1awsFFzIWj5+0CqMcYCMuxFDJf2bh+jhdaZWZEqa2w sp+58l5kJSm/tg5qtQbYMxEMxX40tGy0yQtkZGOR/Gy9Buw7robUrsjeQOwIXhw7yZzL JgcnhtVnxPuvZzRm8z1J886PoxQHR/3ADlV2aa7P9sf2/uBacBxmUE95pF6+/xzrWIQe h4Kb1bO9dSRHYNxtyRpfJPWWHdXf5cTsbFYTw8r2lxLER/fw/ai/kiiVdHGgdC/tc4Un rbDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=+07ZF0vhV+iDgSNtpgYgvjiDt2fwmsqUI3y1zso6lMk=; b=EJVfQ5SYB93fFw+FSq108+jD80wd53Z+vVKOT73Hh/AI0wIzIBxDh1WDYP4w0Ef8Ms 3plCKihuD7/1o2gZ5iB/ZXgA/fLuDC6nGcyOMdxgcKJJBsA1Vt8q/gXZSsvvC0Dv1BbJ ixwqgKNnx/lqbn3aVzoe8UaxoRIPJDDMWLucWSVc4oYpdjqn5JWymMQ2Kb/4QYZ9PSXS 9ThMDaTBDp80AMBsQRAL0ypry2LhhQ/dsF48odSLAFJNq52p6hAFJHIsgD5PO+mLdMwO yo8DJlRojUMivbJ3JARNm2uCrKA+zFvoNDhLy1S2PBCGJShVUJSagRT3Cht7ng1bXaIu 9QXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hcsa7Zu+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c198si1573858oig.142.2020.04.08.15.09.11; Wed, 08 Apr 2020 15:09:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hcsa7Zu+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726555AbgDHWIe (ORCPT + 99 others); Wed, 8 Apr 2020 18:08:34 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:55897 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726483AbgDHWIe (ORCPT ); Wed, 8 Apr 2020 18:08:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586383713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=+07ZF0vhV+iDgSNtpgYgvjiDt2fwmsqUI3y1zso6lMk=; b=Hcsa7Zu+7j/kLI4pHDOA/E8xeU6wejBlqJeH6tJqk5ki4qx4sLp8Umawxx1sd6pRohFjXr jq12GAPzwLy2X3k9+BJKINGwGNCoSjv45nWV0FgZwYBILtBkKoveTx/5bpneLZwPAX94YY q9pn0zf9T3nfbnMmVIWShtkwZxXLnJk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-fWbpv2IoNLOtV8qPfljB5g-1; Wed, 08 Apr 2020 18:08:27 -0400 X-MC-Unique: fWbpv2IoNLOtV8qPfljB5g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 893811007280; Wed, 8 Apr 2020 22:08:26 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-15.gru2.redhat.com [10.97.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0666118F4A; Wed, 8 Apr 2020 22:08:20 +0000 (UTC) From: Wainer dos Santos Moschetta To: pbonzini@redhat.com, kvm@vger.kernel.org Cc: drjones@redhat.com, david@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH v4 0/2] selftests: kvm: Introduce the mem_slot_test test Date: Wed, 8 Apr 2020 19:08:16 -0300 Message-Id: <20200408220818.4306-1-wainersm@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series introduces a new KVM selftest (mem_slot_test) that goal is to verify memory slots can be added up to the maximum allowed. An extra slot is attempted which should occur on error. The patch 01 is needed so that the VM fd can be accessed from the test code (for the ioctl call attempting to add an extra slot). I ran the test successfully on x86_64, aarch64, and s390x. This is why it is enabled to build on those arches. - Changelog - v3 -> v4: - Discarded mem_reg_flags variable. Simply using 0 instead [drjones] - Discarded kvm_region pointer. Instead passing a compound literal in the ioctl [drjones] - All variables are declared on the declaration block [drjones] v2 -> v3: - Keep alphabetical order of .gitignore and Makefile [drjones] - Use memory region flags equals to zero [drjones] - Changed mmap() assert from 'mem != NULL' to 'mem != MAP_FAILED' [drjones] - kvm_region is declared along side other variables and malloc()'ed later [drjones] - Combined two asserts into a single 'ret == -1 && errno == EINVAL' [drjones] v1 -> v2: - Rebased to queue - vm_get_fd() returns int instead of unsigned int (patch 01) [drjones] - Removed MEM_REG_FLAGS and GUEST_VM_MODE defines [drjones] - Replaced DEBUG() with pr_info() [drjones] - Calculate number of guest pages with vm_calc_num_guest_pages() [drjones] - Using memory region of 1 MB sized (matches mininum needed for s390x) - Removed the increment of guest_addr after the loop [drjones] - Added assert for the errno when adding a slot beyond-the-limit [drjones] - Prefer KVM_MEM_READONLY flag but on s390x it switch to KVM_MEM_LOG_DIRTY_PAGES, so ensure the coverage of both flags. Also somewhat tests the KVM_CAP_READONLY_MEM capability check [drjones] - Moved the test logic to test_add_max_slots(), this allows to more easily add new cases in the "suite". v1: https://lore.kernel.org/kvm/20200330204310.21736-1-wainersm@redhat.com Wainer dos Santos Moschetta (2): selftests: kvm: Add vm_get_fd() in kvm_util selftests: kvm: Add mem_slot_test test tools/testing/selftests/kvm/.gitignore | 1 + tools/testing/selftests/kvm/Makefile | 3 + .../testing/selftests/kvm/include/kvm_util.h | 1 + tools/testing/selftests/kvm/lib/kvm_util.c | 5 ++ tools/testing/selftests/kvm/mem_slot_test.c | 76 +++++++++++++++++++ 5 files changed, 86 insertions(+) create mode 100644 tools/testing/selftests/kvm/mem_slot_test.c -- 2.17.2