Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1108998ybb; Wed, 8 Apr 2020 16:55:54 -0700 (PDT) X-Google-Smtp-Source: APiQypKVgTB61SkCqgxUMMu1pmtyHNjxZY/ExIxbUylObJdb2sPv9x7l455LYAKcdL1iiD8CbXvj X-Received: by 2002:aca:6087:: with SMTP id u129mr967301oib.35.1586390154586; Wed, 08 Apr 2020 16:55:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586390154; cv=none; d=google.com; s=arc-20160816; b=e5wKknWTQhhQKyTJXmMYAhWwj78zNBg2+ndqqnfU/SqNlyaQ2htfXC1b3xT8jZYPH8 L8ymAUdShYXzb42oO25bnC2nf+s5Ptis3fywVjrnoPd4fzABcqpB66D+RtLoLmpcXMdL lbg6/HRt6kAXGS3KXzuUmsnXV2BQEnL9CIRrxJ63VrhctZ1xP8KPS0Ex77c5N64x21ly gG2H+TS+LbMuY1gUp+xSuyHjXmiI8yas9u6aThRX7DKwl+UWuMLYBac+M/reCg7A8HtK jmRF1flBDn6+CenKX2G+w8Q+FbdC74QQcUd/2wUsZ1DqOOeFk1XOZ6wdvjjZaz4vyYFd W4cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=CG/nFJcBO28qH6pbni+tt3PLdx3fNA7tHMpYlv7VyVY=; b=lr2UENbx34x242xqbc1+oXfcsXqduw4FgSc9eo7rzuQDXgjsIRUf2tYp7tB0o3+/vK R3flh9CqhdGlqYQKKKyqhP68+fkdwwPajz2It2S7BAP3y9fyCGXZD9XBdWQq5Z1pAZQk wM8dVeu5WzNjRwhMLCGw/PrTm41cMuXdX7uoODuh2vOwGPvX/LB9DhoSMV/k4OKUKuja p7a1b4siUdSA10fGPmLBs1lztPiBCt+eXUurnSH+U6NlDCDeXlO6loYivJ6ao8umTgZj Yusm+TuftwDxlC0TDoRB6Oqf1Tk4XpX+uPtS140Vx+4v+2NR9M805FPECq8C8+ZQNYDL 8SLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t193si2631569oih.61.2020.04.08.16.55.40; Wed, 08 Apr 2020 16:55:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbgDHXxm (ORCPT + 99 others); Wed, 8 Apr 2020 19:53:42 -0400 Received: from mail5.windriver.com ([192.103.53.11]:40794 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726578AbgDHXxm (ORCPT ); Wed, 8 Apr 2020 19:53:42 -0400 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id 038NqZ8o002758 (version=TLSv1 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 8 Apr 2020 16:52:45 -0700 Received: from sc2600cp.corp.ad.wrs.com (128.224.56.62) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.487.0; Wed, 8 Apr 2020 16:52:24 -0700 From: Paul Gortmaker To: Peter Zijlstra CC: , , Paul Gortmaker Subject: [PATCH] perf/x86/intel/pt: drop pointless NULL assignment. Date: Wed, 8 Apr 2020 19:52:16 -0400 Message-ID: <20200408235216.108980-1-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Only a few lines below this removed line is this: attrs = kzalloc(size, GFP_KERNEL); and since there is no code path where this could be avoided, the NULL assignment is a pointless relic of history and can be removed. Cc: Peter Zijlstra Signed-off-by: Paul Gortmaker diff --git a/arch/x86/events/intel/pt.c b/arch/x86/events/intel/pt.c index 1db7a51d9792..e94af4a54d0d 100644 --- a/arch/x86/events/intel/pt.c +++ b/arch/x86/events/intel/pt.c @@ -226,8 +226,6 @@ static int __init pt_pmu_hw_init(void) pt_pmu.vmx = true; } - attrs = NULL; - for (i = 0; i < PT_CPUID_LEAVES; i++) { cpuid_count(20, i, &pt_pmu.caps[CPUID_EAX + i*PT_CPUID_REGS_NUM], -- 2.17.1