Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1130865ybb; Wed, 8 Apr 2020 17:28:47 -0700 (PDT) X-Google-Smtp-Source: APiQypKMVuVIJ622joMbCDcx1gJcACh4SiB8Xk0XMpEUjO5w2BqDII94Ne6jEbwhN5GKr0lOvD1E X-Received: by 2002:a9d:7389:: with SMTP id j9mr6758954otk.56.1586392127729; Wed, 08 Apr 2020 17:28:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586392127; cv=none; d=google.com; s=arc-20160816; b=sOTPNy/ZMgNFBx1CDtws7dQiMScLPnGYJFt0zhFqiFsf09Mxtdxk1EaJP+BmDQ2nrQ pLpxLqPuXwCiPSEIyeFzTIjwuyYZU6agsABnG47se8wJBNVkoKnhU9aooNyrUyk8DWiJ qMA6U6hErNSR54qtd5/o4f1pTACCcB7XyKfApY4BDU1JTA0Ga6of3nGPWB+y6tPMemXu Rv9Yiq5/1mPbUVfgzEeiI/WsehlSxjSWmnstquHOIY1FkkgPqTzkmAMd19gDcv01vsn2 VXJ7op6SlnkbrWiSiB+8M0YxE/02NF9+Y2EdgRs2iIc1vFgl8UwM5IyJn5uVSBLwr/d3 2IfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qFJEzuH25W4SCGGYNZg460xFUSSKgAKY+9+pGr7Dzbo=; b=hBtO8cigNMEycK/32+jD+4TNDE5k3Rt3vf74fbbOkAzcgBKB9y7+Rs2CiPoyBoA4dO YHLl5ESyY+f7czUBDEdo2qWpQw/44vzyEXBWkHx72zUzb4s2uBfMFmqM9ljnUbvhYtrq u1anD0pS9Vj++qeFPc8oBR9TYjMsX3RiBNNwnbIH7ABw2496qkysLftmjLRAxGf7NMhg Jrhl+6fZl0yMgBGsDN6/FiJhrTMXJ6mqr45PZbNTYs+bBVt4qCPlxjU3qdYFcRaTMaWM pfA36fAYfrK+6xk6DQcHTMBiyofulwLfu2NadorBllUzGdSRJmi+aFipyk58ZVKcURJI IpTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ozlabs.org header.s=201707 header.b="NjxzIf/o"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ozlabs.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si3724688oti.128.2020.04.08.17.28.33; Wed, 08 Apr 2020 17:28:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ozlabs.org header.s=201707 header.b="NjxzIf/o"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ozlabs.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726578AbgDIA1c (ORCPT + 99 others); Wed, 8 Apr 2020 20:27:32 -0400 Received: from ozlabs.org ([203.11.71.1]:35731 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbgDIA1b (ORCPT ); Wed, 8 Apr 2020 20:27:31 -0400 Received: by ozlabs.org (Postfix, from userid 1003) id 48yMRQ0WdXz9sSh; Thu, 9 Apr 2020 10:27:30 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1586392050; bh=PXWqFh1mTRtSfkLYqDCpfqsvhI4Y1xX85iXsAE9NlLE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NjxzIf/odfgyCxNtI8je4VE2dZ2Bzcz122kihpbHoAw/Ae2WQw2wa9wk7O+aYFVNn A/pmbHDporQyrH6Z09iBDfRcOoF9gE2q5nD2qofTLQjENjXdWq8ACrFs5CEnSFaLgb eXFkDf+H5DGMv0LXbg9ekVJym/ZQVOPzinKMiOq8HXJ5WlzZuSazi9wIACyerwj8aw Bq52rAudxqAmK8wbDOYyZH2UvCq5P3jTkvbL9bJYY6D4MRRBldrPwLCr+/BED1SkxV husjklN76TLvgkgYZRL8N9TAnvsgH58JzZqqLkKvRYJcOT6w7ShNKBJ2rjlpctCAzr qr7IsAxhKmEgA== Date: Thu, 9 Apr 2020 10:27:26 +1000 From: Paul Mackerras To: Michael Ellerman Cc: Leonardo Bras , Nicholas Piggin , Alexios Zavras , Benjamin Herrenschmidt , Christophe Leroy , Greg Kroah-Hartman , Enrico Weigelt , peterz@infradead.org, Thomas Gleixner , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v3 1/1] ppc/crash: Reset spinlocks during crash Message-ID: <20200409002726.GA5135@blackberry> References: <20200401000020.590447-1-leonardo@linux.ibm.com> <871rp6t9di.fsf@mpe.ellerman.id.au> <02e74be19534ab1db2f16a0c89ecb164e380c12a.camel@linux.ibm.com> <1585895551.7o9oa0ey62.astroid@bobo.none> <87v9majhh2.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v9majhh2.fsf@mpe.ellerman.id.au> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 08, 2020 at 10:21:29PM +1000, Michael Ellerman wrote: > > We should be able to just allocate the rtas_args on the stack, it's only > ~80 odd bytes. And then we can use rtas_call_unlocked() which doesn't > take the global lock. Do we instantiate a 64-bit RTAS these days, or is it still 32-bit? In the old days we had to make sure the RTAS argument buffer was below the 4GB point. If that's still necessary then perhaps putting rtas_args inside the PACA would be the way to go. Paul.