Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1207310ybb; Wed, 8 Apr 2020 19:34:16 -0700 (PDT) X-Google-Smtp-Source: APiQypK3qCKagcQt7jxncTPDVXTpzPMQEyiMI2NtRAoE91xIC0EwISfC/8ljyf8CAGIwy7BLFMr9 X-Received: by 2002:a9d:70d9:: with SMTP id w25mr1946914otj.39.1586399656123; Wed, 08 Apr 2020 19:34:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586399656; cv=none; d=google.com; s=arc-20160816; b=jMDP6EgEXTP8woQkGtEmCpvuYFOaT3TD8goRpjaR4ERSFhdLwCcVF91nCAifkVI5Mc 6OXntACobh+wN3fiMMeXs7f3w4FC89hnmsTzA9rrIF8aT3zJDPBE/Uo2aNVUhpfwGqIg vlH1F5nUdfjuB+O2RPAOz6VvbL5mHWso6YQjOahIpHpHRt6EQ/D0nKJ0Vqj3/AKMzNfx Z1DJwx+mvTqnLxIdxPZWaZJUBvfonQeC2mPJ81+tlMZb/bxQDuRaiAh9dnWZdI/HyWeW QKn15VSBSDiuDqIt7j1HB90MwtmoluhqgxCxmu8o9cl+WQ5gBmiSOUE9UhPl9JLiwXA+ CRKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=7OR2aT5+WGqFUS5SIp/439VlIZIqgSUeTDvlyOWDYgk=; b=y+TMP3qMppzL3o5lkbcIDkNyUC36cQy+AzRX5h5NeG7biOm6dP1ymousqS3mkO/uQH ZsW+ZGOqbBoAaO7h4xU6di4ZkzkhK2nClGkRAoF9FHamFpyWgAjTv73U2q44K/Y9/b/8 95KIbUwucEWv/HgX1ZXXTqQLkXXlhfrWrAoDjL2BdxRObAkz3MZLree7TgZHwhr+r6KA DaVbAOEFopoxpQD9xexrPFzWD9pdwoI1mwAt7yVBLNYioN+gy9FRGc29//jQbumK4wqT vjkQw34tjK9bV7Ft0hjT/bBHaXW5f/XoezrY0/YRJnsF21OguNFVB4cRNWvqwTsZL+L1 D7NQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x73si3157918oif.16.2020.04.08.19.34.01; Wed, 08 Apr 2020 19:34:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726647AbgDICcF (ORCPT + 99 others); Wed, 8 Apr 2020 22:32:05 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:35574 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726523AbgDICcE (ORCPT ); Wed, 8 Apr 2020 22:32:04 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id F1524DF3F5850194B77B; Thu, 9 Apr 2020 10:31:54 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 9 Apr 2020 10:31:49 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: introduce sysfs/data_io_flag to attach REQ_META/FUA To: Jaegeuk Kim CC: , , References: <20200403161249.68385-1-jaegeuk@kernel.org> <0e627c29-7fb0-5bd6-c1d9-b96a94df62ae@huawei.com> <20200407025913.GB137081@google.com> <2ca452cd-073a-29fa-1884-99ad1199bb97@huawei.com> <20200409022005.GA110440@google.com> <69df999a-1df2-595e-579d-a8c3fc700d7b@huawei.com> <20200409022802.GC110440@google.com> From: Chao Yu Message-ID: Date: Thu, 9 Apr 2020 10:31:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200409022802.GC110440@google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/9 10:28, Jaegeuk Kim wrote: > On 04/09, Chao Yu wrote: >> On 2020/4/9 10:20, Jaegeuk Kim wrote: >>> On 04/07, Chao Yu wrote: >>>> On 2020/4/7 10:59, Jaegeuk Kim wrote: >>>>> On 04/07, Chao Yu wrote: >>>>>> On 2020/4/4 0:12, Jaegeuk Kim wrote: >>>>>>> This patch introduces a way to attach REQ_META/FUA explicitly >>>>>>> to all the data writes given temperature. >>>>>>> >>>>>>> -> attach REQ_FUA to Hot Data writes >>>>>>> >>>>>>> -> attach REQ_FUA to Hot|Warm Data writes >>>>>>> >>>>>>> -> attach REQ_FUA to Hot|Warm|Cold Data writes >>>>>>> >>>>>>> -> attach REQ_FUA to Hot|Warm|Cold Data writes as well as >>>>>>> REQ_META to Hot Data writes >>>>>> >>>>>> Out of curiosity, what scenario it is used for? >>>>> >>>>> It's testing purpose to compare the bandwidths per different IO flags. >>>> >>>> Thanks for the hint. :) >>>> >>>> As nobarrier was set in Android, so REQ_PREFLUSH will not be considered in >>>> this sysfs interface? >>> >>> I don't see any diff on performance, so not interesting. :) >> >> I doubt it may has diff on non-ufs/emmc device? just guess. > > I don't have any data on emmc, so maybe. Which case do we send REQ_PREFLUSH? fsync w/ barrier mount option. > >> >> Thanks, >> >>> >>>> >>>> Thanks, >>>> >>>>> >>>>>> >>>>>> Thanks, >>>>> . >>>>> >>> . >>> > . >