Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] signal: check sig before setting info in
 kill_pid_usb_asyncio
To:     Christian Brauner <christian.brauner@ubuntu.com>
CC:     <ebiederm@xmission.com>, <oleg@redhat.com>, <tj@kernel.org>,
        <guro@fb.com>, <joel@joelfernandes.org>, <jannh@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mingfangsen <mingfangsen@huawei.com>,
        Yanxiaodan <yanxiaodan@huawei.com>,
        linfeilong <linfeilong@huawei.com>
References: <f525fd08-1cf7-fb09-d20c-4359145eb940@huawei.com>
 <20200330084415.p4v5g6s24innsjrc@wittgenstein>
From:   Zhiqiang Liu <liuzhiqiang26@huawei.com>
Message-ID: <2d00096f-94f7-753e-c05f-14860fed2abe@huawei.com>
Date:   Thu, 9 Apr 2020 11:26:08 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20200330084415.p4v5g6s24innsjrc@wittgenstein>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Friendly ping...

On 2020/3/30 16:44, Christian Brauner wrote:
> On Mon, Mar 30, 2020 at 10:18:33AM +0800, Zhiqiang Liu wrote:
>>
>> In kill_pid_usb_asyncio, if signal is not valid, we do not need to
>> set info struct.
>>
>> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> 
> I'd have done:
> 
> if (!valid_signal(sig))
> 	return -EINVAL;
> 
> instead of setting ret to EINVAL above but that's mostly a matter of style.
> 
> Picking this up unless someone sees a problem with it.
> 
> Thank you!
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> 
> .
>