Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 09 Apr 2020 08:53:47 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <2d00096f-94f7-753e-c05f-14860fed2abe@huawei.com>
References: <f525fd08-1cf7-fb09-d20c-4359145eb940@huawei.com> <20200330084415.p4v5g6s24innsjrc@wittgenstein> <2d00096f-94f7-753e-c05f-14860fed2abe@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [PATCH] signal: check sig before setting info in kill_pid_usb_asyncio
To:     Zhiqiang Liu <liuzhiqiang26@huawei.com>
CC:     ebiederm@xmission.com, oleg@redhat.com, tj@kernel.org, guro@fb.com,
        joel@joelfernandes.org, jannh@google.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mingfangsen <mingfangsen@huawei.com>,
        Yanxiaodan <yanxiaodan@huawei.com>,
        linfeilong <linfeilong@huawei.com>
From:   Christian Brauner <christian.brauner@ubuntu.com>
Message-ID: <EFD902AA-B999-4E13-AC1E-1A28E93435BB@ubuntu.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On April 9, 2020 5:26:08 AM GMT+02:00, Zhiqiang Liu <liuzhiqiang26@huawei.com> wrote:
>Friendly ping...
>
>On 2020/3/30 16:44, Christian Brauner wrote:
>> On Mon, Mar 30, 2020 at 10:18:33AM +0800, Zhiqiang Liu wrote:
>>>
>>> In kill_pid_usb_asyncio, if signal is not valid, we do not need to
>>> set info struct.
>>>
>>> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>> 
>> I'd have done:
>> 
>> if (!valid_signal(sig))
>> 	return -EINVAL;
>> 
>> instead of setting ret to EINVAL above but that's mostly a matter of
>style.
>> 
>> Picking this up unless someone sees a problem with it.
>> 
>> Thank you!
>> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
>> 
>> .
>> 

The patches are queued for after rc1. So around next week.
They came too late to make it into the merge window.

Christian