Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1421546ybb; Thu, 9 Apr 2020 01:36:13 -0700 (PDT) X-Google-Smtp-Source: APiQypKp/IFDcstuETn2kg+ApOAPBYiqQccoIclMW2+yDDb66NUCV56NjoZTntHb8Kbo6yJ098Qb X-Received: by 2002:a9d:2c01:: with SMTP id f1mr9020684otb.67.1586421372933; Thu, 09 Apr 2020 01:36:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586421372; cv=none; d=google.com; s=arc-20160816; b=ozWu1YVZ0Jg02oQU5fn7wDYzdrNBc6NOZqH4A8rwMc7leznyimLcX1jyv47rPLury2 QirkFSk123ED4toqRhK4XjePK8UoNwMaSeJP/qVwdFF8cs+Vx1VFOnj22AB97F0aWCz6 VGrg0VZOztErQ2QyhJbi341U5i3hlYw0YJa1X/65d/vN1rzg34e781HL3XY9AtpNXp/8 oN2SiKT0L4Ll9ry/jDWLBBVVaK2udIZdVazTtTnAxJX0vuB65II2LQywuWdjvepTUgH1 4pFDN6s2iI6uPTKDS/dlukrKboYfDR3RYwCJTiU/CoXyOLsOiKjuJFA5tXArRbJAl/ul mKcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ndAVXbmy0H3dqOxrxACyPH778FIXF2JLmyKmugaQXr8=; b=Qc8FNqXrk5hg6jSbXIKxCDcO+mVlxBfqhffAsE5nbbgIAFBLpqNQSOZG7HcR7V6Y7l QVnKXicBxbJoJr+ukYfdaMX5uGoBOme35nMai1YGBV9dec1Jj3KYE452zzKgEE1/IAS2 2P5qR2KIV7wC0o6Jbht5usZ6cYPZnmbNjF1iJigswRWnUFlEQ12qftAfvcZQEuDY7Hpt yX2fCoGOVBCep2ahkndtAbpMijBpRyzB4eTDBsvNhulX5qbOqVGQgpasSflO6IwURJ58 rdw65kx6W7FwbFQLpFjOyeEYysSEUnNeVJgcf0M/doZuxBKZmEO6Oz43qtgR0bNQAIzW FkqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d1si3530979oth.18.2020.04.09.01.35.58; Thu, 09 Apr 2020 01:36:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726690AbgDIIfQ (ORCPT + 99 others); Thu, 9 Apr 2020 04:35:16 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:40789 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726470AbgDIIfQ (ORCPT ); Thu, 9 Apr 2020 04:35:16 -0400 Received: from ip5f5bd698.dynamic.kabel-deutschland.de ([95.91.214.152] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jMSci-0007C4-7g; Thu, 09 Apr 2020 08:33:20 +0000 Date: Thu, 9 Apr 2020 10:33:19 +0200 From: Christian Brauner To: Christoph Hellwig Cc: Jens Axboe , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-api@vger.kernel.org, Jonathan Corbet , Serge Hallyn , "Rafael J. Wysocki" , Tejun Heo , "David S. Miller" , Saravana Kannan , Jan Kara , David Howells , Seth Forshee , David Rheinsberg , Tom Gundersen , Christian Kellner , Dmitry Vyukov , =?utf-8?B?U3TDqXBoYW5l?= Graber , linux-doc@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/8] loopfs: implement loopfs Message-ID: <20200409083319.nlemf6d7g33hxhiy@wittgenstein> References: <20200408152151.5780-1-christian.brauner@ubuntu.com> <20200408152151.5780-3-christian.brauner@ubuntu.com> <20200409075320.GA26234@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200409075320.GA26234@infradead.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 09, 2020 at 12:53:20AM -0700, Christoph Hellwig wrote: > Almost 600 lines of code for a little bit of fine grained control > is the wrong tradeoff. Please find a cheaper way to do this. I think that's a slight misrepresentation of the patchset. Of course, I get reservations against adding new code but none of this code will exist at all if the config option is not set; and the config option is not selected by default. I don't want people to have to use something they don't care about of course. The patchset itself unblocks a range of use-cases we had issues with for quite a while and the standalone, tiny filesystem approach has served us well already, so this is not something new. It's not just gaining fine-grained control, it's a whole set of new uses and we don't just do it for the fun of doing it but because we do have actual users of this. Christian