Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1430733ybb; Thu, 9 Apr 2020 01:53:25 -0700 (PDT) X-Google-Smtp-Source: APiQypLDrMmBRYT8BIHJgV4Xco4XIgIFfPj2Sdl2CEL7sb3i4EOW6Fr0fwCKbgUtuiM27bWB4BYX X-Received: by 2002:aca:4f57:: with SMTP id d84mr2731477oib.161.1586422405657; Thu, 09 Apr 2020 01:53:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586422405; cv=none; d=google.com; s=arc-20160816; b=UcHUkQOLTAuCJexuavRwls7TMEMXcp9EbqZJsgtfZ3+4QbmPGz8PLomcTNLaKRdvyZ aSXwgF9IpjmGIEAjZwKpI+mkFkkRdt0tm8uPfML2i4aH6246Bsaab7DLY4tLXe1Cmyc6 i09s3qEEcUZNwj1bbcWvOxFtTzYnQkdhLHCuPT6VQd+QG7Vkgw9/wx8OMxqAHJlmVoj9 l6vUEKd0r+s7P25wM0EN6HM0ygT4E/Y2YcWYTNkqOVQNqvN7kDu1d2hOhVOwyKPXMPxr 2CNVpgaxF8cmbKgZD9P6Q6SquXfKwQLLe598R1tGTu1PdLi5hzBQAJnKyP9JUKxO8zZh ds+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=8Cn84oNkFDW/MXErxF6bDvT454dl8SmLE4LIf0AVcsw=; b=D4z+LZav4nJVjX2ksCNjTc7ov253PreF8943eQc+5YuplhXGU1arzOoR1BDKaS4NlJ aUhjtZoChuYznJR5oNVw1ch9Fn6y0bUN4RJ7XcjK1AOv/YUUo24Eptvphtey1arFgDyI jzJI6NZeTVvS7Sn0IavzSCtIPm9dyf9RkO45JE2zhK38ghH1D8dmZMp0RjkkD/YwDBRt iralOcWYXUKcIuzuzJ9qCdIRZENuybSRi1vVnon0D6HGPpMe5rKUXnP1PSu0EZZkpB4e fhdmdro0bHdxIsJtwqIIO00hHHIjdhCXA63gMWFpTmWVMVYU1iwf4B1S6ZMoNSGwe2Lp dKog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q11si3674265otm.263.2020.04.09.01.53.11; Thu, 09 Apr 2020 01:53:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726722AbgDIIu5 (ORCPT + 99 others); Thu, 9 Apr 2020 04:50:57 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:12626 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726702AbgDIIu4 (ORCPT ); Thu, 9 Apr 2020 04:50:56 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 0F84898B1BD6B12F272A; Thu, 9 Apr 2020 16:50:49 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Thu, 9 Apr 2020 16:50:38 +0800 From: Jason Yan To: , , , , CC: Jason Yan Subject: [PATCH] scsi: qla1280: make qla1280_firmware_mutex and qla1280_fw_tbl static Date: Thu, 9 Apr 2020 16:49:10 +0800 Message-ID: <20200409084910.44336-1-yanaijie@huawei.com> X-Mailer: git-send-email 2.17.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following sparse warning: drivers/scsi/qla1280.c:529:1: warning: symbol 'qla1280_firmware_mutex' was not declared. Should it be static? drivers/scsi/qla1280.c:538:15: warning: symbol 'qla1280_fw_tbl' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/scsi/qla1280.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index 3337cd341d21..441a45349349 100644 --- a/drivers/scsi/qla1280.c +++ b/drivers/scsi/qla1280.c @@ -526,7 +526,7 @@ static struct pci_device_id qla1280_pci_tbl[] = { }; MODULE_DEVICE_TABLE(pci, qla1280_pci_tbl); -DEFINE_MUTEX(qla1280_firmware_mutex); +static DEFINE_MUTEX(qla1280_firmware_mutex); struct qla_fw { char *fwname; @@ -535,7 +535,7 @@ struct qla_fw { #define QL_NUM_FW_IMAGES 3 -struct qla_fw qla1280_fw_tbl[QL_NUM_FW_IMAGES] = { +static struct qla_fw qla1280_fw_tbl[QL_NUM_FW_IMAGES] = { {"qlogic/1040.bin", NULL}, /* image 0 */ {"qlogic/1280.bin", NULL}, /* image 1 */ {"qlogic/12160.bin", NULL}, /* image 2 */ -- 2.17.2