Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 9 Apr 2020 11:10:16 +0200
From:   Robert Richter <rrichter@marvell.com>
To:     Jason Yan <yanaijie@huawei.com>
CC:     <khuong@os.amperecomputing.com>, <bp@alien8.de>,
        <mchehab@kernel.org>, <tony.luck@intel.com>, <james.morse@arm.com>,
        <linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC, xgene: remove set but not used 'address'
Message-ID: <20200409091016.d3uohmt2o3zwhmro@rric.localdomain>
References: <20200409085237.46642-1-yanaijie@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200409085237.46642-1-yanaijie@huawei.com>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from rric.localdomain (31.208.96.227) by HE1PR0901CA0049.eurprd09.prod.outlook.com (2603:10a6:3:45::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.16 via Frontend Transport; Thu, 9 Apr 2020 09:10:24 +0000
X-Originating-IP: [31.208.96.227]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2567d6ec-e130-4133-666b-08d7dc65d768
X-MS-TrafficTypeDiagnostic: BYAPR18MB2375:
X-Microsoft-Antispam-PRVS: <BYAPR18MB237583794D6DD78F3ED66F35D9C10@BYAPR18MB2375.namprd18.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:514;
X-Forefront-PRVS: 0368E78B5B
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR18MB2661.namprd18.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(136003)(346002)(39850400004)(366004)(396003)(6506007)(9686003)(66476007)(81156014)(478600001)(186003)(55016002)(86362001)(6666004)(8936002)(8676002)(1076003)(53546011)(7696005)(66946007)(5660300002)(66556008)(52116002)(316002)(81166007)(956004)(16526019)(2906002)(6916009)(4326008)(26005);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 9P0lEIk2EoIf+kG5T6PDrUBlo5097Paf7Wg0dakt0qQqZOOiE6u0B8QWuA3muLVTVx8/XWqJo6r3S782MvXk7RgtnkAxaDxKyxxiCbDs/EftRKiwNfzVM+fS+rK7Fqw9p0Kn0cpOI95r4QH/mkTl7tb1esczau0nh73VZlFtcdncGzIGilvhr0tGI3sWHxTL+i/jYes2enUVYwoCAwwym5K4t7eVBzR7MdvoxFugm+UH3tjsbRGFsjKvEozaEprp0ZYvnSY3ZH+Y917F8kobOoMRe5H5NUqW/rlkm0IQUPBjciKU8Qww/hNTkwNxvuYW2gBo0sqUkl8tuT1XARRHNeHUnRIACxQtGlH5ex95RwKa6eouv1gbK1FpoRb8T6xpwpLWdZGnrmJWF5fH57wzdcC9k6jZCqGp+EHtNtF5jEyM9RH2LsguMso0Oe76gYiW
X-MS-Exchange-AntiSpam-MessageData: lEJcO5YyshLHHC/ltM7u45QqOpXbLM29npVIYcxn0S3aMFoS5FIbv6wwpjx4ftl4K/4f2Ypy0gd/hFqGJ6QmEnsVWRusqhdlluurtxM9qVrcbQBsJPXOlJHM+/pkb0+oS+vBnj+jKk74cm7UH6c+TQ==
X-MS-Exchange-CrossTenant-Network-Message-Id: 2567d6ec-e130-4133-666b-08d7dc65d768
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2020 09:10:26.1724
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0m6jfJSFVCAVedFmnUquvQUn/obektAPVD2ZrP/plF/RNNoGFqxl+iRVf2km5GcXSjzFWqUmzbruagwwUXOKfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2375
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676
 definitions=2020-04-09_03:2020-04-07,2020-04-09 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09.04.20 16:52:37, Jason Yan wrote:
> Fix the following gcc warning:
> 
> drivers/edac/xgene_edac.c:1486:7: warning: variable ‘address’ set but
> not used [-Wunused-but-set-variable]
>    u32 address;
>        ^~~~~~~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/edac/xgene_edac.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
> index e4a1032ba0b5..e5e0fbdeca29 100644
> --- a/drivers/edac/xgene_edac.c
> +++ b/drivers/edac/xgene_edac.c
> @@ -1483,13 +1483,11 @@ static void xgene_edac_rb_report(struct edac_device_ctl_info *edac_dev)
>  		return;
>  	if (reg & STICKYERR_MASK) {
>  		bool write;
> -		u32 address;
>  
>  		dev_err(edac_dev->dev, "IOB bus access error(s)\n");
>  		if (regmap_read(ctx->edac->rb_map, RBEIR, &reg))
>  			return;
>  		write = reg & WRITE_ACCESS_MASK ? 1 : 0;
> -		address = RBERRADDR_RD(reg);

Please also remove that unused macro.

Thanks,

-Robert

>  		if (reg & AGENT_OFFLINE_ERR_MASK)
>  			dev_err(edac_dev->dev,
>  				"IOB bus %s access to offline agent error\n",
> -- 
> 2.17.2
>