Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] EDAC, xgene: remove set but not used 'address'
To:     Robert Richter <rrichter@marvell.com>
CC:     <khuong@os.amperecomputing.com>, <bp@alien8.de>,
        <mchehab@kernel.org>, <tony.luck@intel.com>, <james.morse@arm.com>,
        <linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20200409085237.46642-1-yanaijie@huawei.com>
 <20200409091016.d3uohmt2o3zwhmro@rric.localdomain>
From:   Jason Yan <yanaijie@huawei.com>
Message-ID: <1185c697-026d-74c9-3f67-e95bebdc4c00@huawei.com>
Date:   Thu, 9 Apr 2020 17:15:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.2
MIME-Version: 1.0
In-Reply-To: <20200409091016.d3uohmt2o3zwhmro@rric.localdomain>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


在 2020/4/9 17:10, Robert Richter 写道:
> On 09.04.20 16:52:37, Jason Yan wrote:
>> Fix the following gcc warning:
>>
>> drivers/edac/xgene_edac.c:1486:7: warning: variable ‘address’ set but
>> not used [-Wunused-but-set-variable]
>>     u32 address;
>>         ^~~~~~~
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>>   drivers/edac/xgene_edac.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
>> index e4a1032ba0b5..e5e0fbdeca29 100644
>> --- a/drivers/edac/xgene_edac.c
>> +++ b/drivers/edac/xgene_edac.c
>> @@ -1483,13 +1483,11 @@ static void xgene_edac_rb_report(struct edac_device_ctl_info *edac_dev)
>>   		return;
>>   	if (reg & STICKYERR_MASK) {
>>   		bool write;
>> -		u32 address;
>>   
>>   		dev_err(edac_dev->dev, "IOB bus access error(s)\n");
>>   		if (regmap_read(ctx->edac->rb_map, RBEIR, &reg))
>>   			return;
>>   		write = reg & WRITE_ACCESS_MASK ? 1 : 0;
>> -		address = RBERRADDR_RD(reg);
> 
> Please also remove that unused macro.
> 

OK, thanks.

Jason

> Thanks,
> 
> -Robert
> 
>>   		if (reg & AGENT_OFFLINE_ERR_MASK)
>>   			dev_err(edac_dev->dev,
>>   				"IOB bus %s access to offline agent error\n",
>> -- 
>> 2.17.2
>>
>