Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1514344ybb; Thu, 9 Apr 2020 03:46:43 -0700 (PDT) X-Google-Smtp-Source: APiQypLrKMi4TcOiDP77lJ/oxdVONxgCCc5wPNkdJkxeu5vdIViRim6PxPctB3+eKt6JAAyctdQh X-Received: by 2002:a05:6830:2017:: with SMTP id e23mr7918865otp.329.1586429203831; Thu, 09 Apr 2020 03:46:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586429203; cv=none; d=google.com; s=arc-20160816; b=Gc/u/73CCKKmTL5318/iCzbLEDY1Ut+AkEpy90X2vHa9gwr1VDXZ14YVVYSpHQdfAR 0OQOgxhWA8XLLSRrqwwa1HMIjekBxiFuZyRKY3abI+x4NOfO0NIJaMUWQLDzikfQJ4rL AgHmU91pjxzwKnoHKj2qKYRl/4bUXas7Vdv1rFqthi0PJtXwqSbvyJ5VvJL9zjRmPm95 7cOgRV2IBJAylwdwOLwnMXabyk4whmR5R+qJTWCgZcUD8/qsz7e6ALCBminfYqsxSMcR 7jzeyH+FdqRP3ddw2EL1zdJbSVuXbGf3fhOciKKRuFq/XJdiHKbWBWzyTa5lip7ZLK1I R8Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Wu0n0VEPIvCA21wPkP0rs4i7dJuLN7oCjGkTWRChhGQ=; b=lyJZG5q4dngN7/P3PECNETi887mwRpx5BkD9UgoZo8nWY8DgbrQUCqlfUk/MU3o2NV vCjpNtl2KrvE6MhIwSrn5bRl6PGOzsaPqh5kAudqcmiDY6+uAgeK5u5nARXrfT5ybIBg 7FV1UkbsbSJ1Fch//mTMpf6X9Rab+NIC2sgnjzTX8Yqdy038QOzQuI6zbkNVbNJkGLqB Xd6vKHtTnjWUhYKgAJL0SyleWWw0F3D0FFSpYbHuZm0JRGYgvN3wgYs166Kv48+nUi/p GCAUA8CdLzOgMddt6fDL7QWcP9rmi/jL3Mq589GVOC8VkphV2Vhd3knfJrM90suKi9iQ dQXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LNFrHuPs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u12si4099914otg.9.2020.04.09.03.46.29; Thu, 09 Apr 2020 03:46:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LNFrHuPs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726589AbgDIKpt (ORCPT + 99 others); Thu, 9 Apr 2020 06:45:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:34898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725783AbgDIKps (ORCPT ); Thu, 9 Apr 2020 06:45:48 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 73EC820857; Thu, 9 Apr 2020 10:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586429149; bh=Bj4KCi4Ibg5oo9TbDcevGuX/4djzmyiF0/NqHpujLqQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LNFrHuPszFFuiny384iC1PwRmTLzv4HQZNyo/jrxoac4fWOVWAPGFo/+wZOT2LuKu X97cz7kC1A/dUII7JG5bbJ5LASWAjI/vznxf653JbVBgn+4Euav7vLeb9o4kKJ8U8G 8l+vYYuekSh6cJ94lnWD1cjCmvRDjvfGUmtJbGmY= Date: Thu, 9 Apr 2020 11:45:46 +0100 From: Mark Brown To: Baolin Wang Cc: lee.jones@linaro.org, arnd@arndb.de, orsonzhai@gmail.com, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/3] regmap: Add reg_update_bits() support Message-ID: <20200409104546.GA5399@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u3/rZRmxL6MmkK24" Content-Disposition: inline In-Reply-To: X-Cookie: HUGH BEAUMONT died in 1982!! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --u3/rZRmxL6MmkK24 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 09, 2020 at 04:57:58PM +0800, Baolin Wang wrote: > Add reg_update_bits() support in case some platforms use a special method > to update bits of registers. >=20 > Signed-off-by: Baolin Wang > --- > drivers/base/regmap/regmap-mmio.c | 29 ++++++++++++++++++++++++++++- > drivers/base/regmap/regmap.c | 1 + MMIO devices clearly don't physically have an update_bits() operation so this should be implemented further up the stack where it applies to all buses without physical support. --u3/rZRmxL6MmkK24 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6O/NcACgkQJNaLcl1U h9DjRgf+IP/u9nUEoNtZLGYFiBKynZ6dn873JFvLn2vt0eHtxyyxscgijvgMfV/K DeVYVYmwbnc2/YVjVbNWna7fhvNgjVxWx23JH1AyUCGBJm58a5QVht3k0SJaWx6/ wUDpjGNzdJbyZfMo+ifhzr6/4gqnoylniIAVntbuFoPkHoCg5F5QGdVmje7YwC3z VaMLNNxKW1egPjy7JZ7f+K/08yjKURsMkZ6793ebYl00s9Xf49JSse/0szNilBjj 2r7Te/+wHtBYmFRe2dP0jwqQLE89KmSuHy7ONHuaLSdVkyiD1UVVLS2EsFwMF4Dk IxzikTfhuUw5IT02gSckH9+KCxC2Dw== =Kfcm -----END PGP SIGNATURE----- --u3/rZRmxL6MmkK24--