Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 9 Apr 2020 14:02:42 +0200
From:   Oliver Graute <oliver.graute@gmail.com>
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     dmitry.torokhov@gmail.com,
        Oliver Graute <oliver.graute@kococonnector.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sasha Levin <sashal@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] Input: edt-ft5x06 - fix crash on EDT EP0110M09
Message-ID: <20200409120242.GA17410@portage>
References: <1586424425-27038-1-git-send-email-oliver.graute@gmail.com>
 <20200409105253.qvezbikpbnrkig52@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200409105253.qvezbikpbnrkig52@pengutronix.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09/04/20, Marco Felsch wrote:
> Hi Oliver,
> 
> thanks for your patch.
> 
> On 20-04-09 11:27, Oliver Graute wrote:
> > From: Oliver Graute <oliver.graute@kococonnector.com>
> 
> ...
> 
> >  drivers/input/touchscreen/edt-ft5x06.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> > index 06aa8ba0b6d7..6fbc87d041a1 100644
> > --- a/drivers/input/touchscreen/edt-ft5x06.c
> > +++ b/drivers/input/touchscreen/edt-ft5x06.c
> > @@ -819,10 +819,6 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client,
> >  	 * to have garbage in there
> >  	 */
> >  	memset(rdbuf, 0, sizeof(rdbuf));
> > -	error = edt_ft5x06_ts_readwrite(client, 1, "\xBB",
> > -					EDT_NAME_LEN - 1, rdbuf);
> > -	if (error)
> > -		return error;
> 
> 
> I don't see how this call can corrupt the stack..

I admit that this is strange. The patch fixed my problems so I posted
it. Still interested in the root-cause.

Best regards,

Oliver