Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   ebiederm@xmission.com (Eric W. Biederman)
To:     Alexey Gladkov <gladkov.alexey@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Kernel Hardening <kernel-hardening@lists.openwall.com>,
        Linux API <linux-api@vger.kernel.org>,
        Linux FS Devel <linux-fsdevel@vger.kernel.org>,
        Linux Security Module <linux-security-module@vger.kernel.org>,
        Akinobu Mita <akinobu.mita@gmail.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Alexey Gladkov <legion@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        Daniel Micay <danielmicay@gmail.com>,
        Djalal Harouni <tixxdz@gmail.com>,
        "Dmitry V . Levin" <ldv@altlinux.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        "J . Bruce Fields" <bfields@fieldses.org>,
        Jeff Layton <jlayton@poochiereds.net>,
        Jonathan Corbet <corbet@lwn.net>,
        Kees Cook <keescook@chromium.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Oleg Nesterov <oleg@redhat.com>,
        David Howells <dhowells@redhat.com>
References: <20200409123752.1070597-1-gladkov.alexey@gmail.com>
Date:   Thu, 09 Apr 2020 07:59:47 -0500
In-Reply-To: <20200409123752.1070597-1-gladkov.alexey@gmail.com> (Alexey
        Gladkov's message of "Thu, 9 Apr 2020 14:37:44 +0200")
Message-ID: <87y2r4vmpo.fsf@x220.int.ebiederm.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PATCH RESEND v11 0/8] proc: modernize proc to support multiple private instances
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Alexey Gladkov <gladkov.alexey@gmail.com> writes:

> Preface:
> --------
> This is patchset v11 to modernize procfs and make it able to support multiple
> private instances per the same pid namespace.
>
> This patchset can be applied on top of:
>
> git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git
> 4b871ce26ab2


Why the resend?

Nothing happens until the merge window closes with the release of -rc1
(almost certainly on this coming Sunday).  I goofed and did not act on
this faster, and so it is my fault this did not make it into linux-next
before the merge window.  But I am not going to rush this forward.


You also ignored my review and have not even descibed why it is safe
to change the type of a filesystem parameter.

-	fsparam_u32("hidepid",	Opt_hidepid),
+	fsparam_string("hidepid",	Opt_hidepid),


Especially in light of people using fsconfig(fd, FSCONFIG_SET_...);

All I need is someone to point out that fsparam_u32 does not use
FSCONFIG_SET_BINARY, but FSCONFIG_SET_STRING.


My apologies for being grumpy but this feels like you are asking me to
go faster when it is totally inappropriate to do so, while busily
ignoring my feedback.

I think this should happen.  But I can't do anything until after -rc1.

Eric