Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.1586422035.git.baolin.wang7@gmail.com> <759f7471d03946ae273a06f7bcca8a54528ec08c.1586422035.git.baolin.wang7@gmail.com>
 <20200409104802.GB5399@sirena.org.uk>
In-Reply-To: <20200409104802.GB5399@sirena.org.uk>
From:   Baolin Wang <baolin.wang7@gmail.com>
Date:   Thu, 9 Apr 2020 22:13:58 +0800
Message-ID: <CADBw62oh6juAqUR1-U1D73H0oeW1x0gk0XJ01h47ko_Dxy7eEQ@mail.gmail.com>
Subject: Re: [RFC PATCH 1/3] mfd: syscon: Add reg_update_bits() callback support
To:     Mark Brown <broonie@kernel.org>
Cc:     Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 9, 2020 at 6:48 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Apr 09, 2020 at 04:57:57PM +0800, Baolin Wang wrote:
>
> > --- a/include/linux/regmap.h
> > +++ b/include/linux/regmap.h
> > @@ -340,6 +340,8 @@ struct regmap_access_table {
> >   *             read operation on a bus such as SPI, I2C, etc. Most of the
> >   *             devices do not need this.
> >   * @reg_write:         Same as above for writing.
> > + * @reg_update_bits: Optional, should only be provided for devices whose update
> > + *                operation cannot be represented as read and write.
> >   * @fast_io:   Register IO is fast. Use a spinlock instead of a mutex
> >   *             to perform locking. This field is ignored if custom lock/unlock
> >   *             functions are used (see fields lock/unlock of struct regmap_config).
> > @@ -416,6 +418,8 @@ struct regmap_config {
> >
> >       int (*reg_read)(void *context, unsigned int reg, unsigned int *val);
> >       int (*reg_write)(void *context, unsigned int reg, unsigned int val);
> > +     int (*reg_update_bits)(void *context, unsigned int reg,
> > +                            unsigned int mask, unsigned int val);
>
> This is fine, we already have this operation for buses, but why is this
> munged in with the MFD patch?

Originally I want to show a example usage of the new callback, but I
can spilt them into 2 patches as you suggested. Thanks.

-- 
Baolin Wang