Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 9 Apr 2020 15:27:15 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Baolin Wang <baolin.wang7@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] mfd: syscon: Add reg_update_bits() callback
 support
Message-ID: <20200409142715.GF5399@sirena.org.uk>
References: <cover.1586422035.git.baolin.wang7@gmail.com>
 <759f7471d03946ae273a06f7bcca8a54528ec08c.1586422035.git.baolin.wang7@gmail.com>
 <20200409104802.GB5399@sirena.org.uk>
 <CADBw62oh6juAqUR1-U1D73H0oeW1x0gk0XJ01h47ko_Dxy7eEQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="udcq9yAoWb9A4FsZ"
Content-Disposition: inline
In-Reply-To: <CADBw62oh6juAqUR1-U1D73H0oeW1x0gk0XJ01h47ko_Dxy7eEQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--udcq9yAoWb9A4FsZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 09, 2020 at 10:13:58PM +0800, Baolin Wang wrote:
> On Thu, Apr 9, 2020 at 6:48 PM Mark Brown <broonie@kernel.org> wrote:

> > > +     int (*reg_update_bits)(void *context, unsigned int reg,
> > > +                            unsigned int mask, unsigned int val);

> > This is fine, we already have this operation for buses, but why is this
> > munged in with the MFD patch?

> Originally I want to show a example usage of the new callback, but I
> can spilt them into 2 patches as you suggested. Thanks.

Yes, it's good to have an example user - just not as part of the same
patch!

--udcq9yAoWb9A4FsZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6PMMMACgkQJNaLcl1U
h9A9wgf+Jc6tx2qiednYwS1jkTBZj78MElmgKS659xV4M89wyuZsOgy3X0abKOOx
/uebtp84zgOJP97ZmGJtiT19GungspwyqMFghDZVmOw0YtrvJD3jNFU021jkmguy
42kRT+TByrolwmO/q7+A+dRMESc/nO5jXYIYE95dy8I1TRQCs3kPcfIu6ooe35VI
OfiOiDGkxhEU+GvFiy79mvHQMurtX15l9nKoim27HaC6nGqyGCcdb2Ur/YRW0oqd
rAoFmzyig9AKZ+T9nQpQ2UoI54SEjqoNqiLwxCD+FAifXOIw66zIRBqn9wk8JlHX
p4gZNqbYUpOIc8Ar9mq+FmI2ertcLA==
=wXEn
-----END PGP SIGNATURE-----

--udcq9yAoWb9A4FsZ--