Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932328AbWB0P5Q (ORCPT ); Mon, 27 Feb 2006 10:57:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751341AbWB0P5Q (ORCPT ); Mon, 27 Feb 2006 10:57:16 -0500 Received: from smtp.osdl.org ([65.172.181.4]:20943 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751310AbWB0P5P (ORCPT ); Mon, 27 Feb 2006 10:57:15 -0500 Date: Mon, 27 Feb 2006 08:00:42 -0800 From: Stephen Hemminger To: woho@woho.de Cc: pomac@vapor.com, Carl-Daniel Hailfinger , Jeff Garzik , netdev@vger.kernel.org, Pavel Volkovitskiy , Linux Kernel Mailing List Subject: Re: [PATCH] Revert sky2 to 0.13a Message-ID: <20060227080042.0cf3f05d@localhost.localdomain> In-Reply-To: <200602270003.46353.woho@woho.de> References: <4400FC28.1060705@gmx.net> <200602261913.36308.woho@woho.de> <200602262331.47750.woho@woho.de> <200602270003.46353.woho@woho.de> X-Mailer: Sylpheed-Claws 2.0.0 (GTK+ 2.6.10; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2074 Lines: 52 On Mon, 27 Feb 2006 00:03:45 +0100 Wolfgang Hoffmann wrote: > On Sunday 26 February 2006 23:31, Wolfgang Hoffmann wrote: > > On Sunday 26 February 2006 19:13, Wolfgang Hoffmann wrote: > > > Ok, I did some reading and just started a git bisect. I didn't find hints > > > on how to bisect if I'm only interested in changes to sky2.[ch], so I'm > > > taking the full kernel tree and skip testing those bisect steps that > > > didn't change sky2.[ch]. > > > > > > Looking at Carl-Daniels 0.13a and Stephens patch against 0.15 in this > > > thread, I'll patch each bisect step such that sky2_poll() has > > > > > >        sky2_write32(hw, STAT_CTRL, SC_STAT_CLR_IRQ); > > >        if (sky2_read8(hw, STAT_LEV_TIMER_CTRL) == TIM_START) { > > >                sky2_write8(hw, STAT_LEV_TIMER_CTRL, TIM_STOP); > > >                sky2_write8(hw, STAT_LEV_TIMER_CTRL, TIM_START); > > >         } > > > > > > after exit_loop. Is that ok? > > > > > > I'll report as soon as I have results. > > > > Bisect done: > > > > 4d52b48b43d0d1d5959fa722ee0046e3542e5e1b is first bad commit > > [PATCH] sky2: support msi interrupt (revised) > > > > Reverting this commit in git head seems to work, at least the driver builds > > and loads. Is that sane? > > > > I'm currently testing this (without any further modifications), let's see > > if it hangs or not. > > Ok, no hangs yet. > > This version passed a test scenario only 0.13a has survived so far. I'll > continue to use this to give it more testing tomorrow. > > Looking at the reverted commit, I wonder if modprobing sky2 with disable_msi=1 > is equivalent to reverting the commit? > Could you try the current code with the disable_msi option? modprobe sky2 disable_msi=1 That will run existing code without MSI. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/