Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 9 Apr 2020 17:43:32 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Jin Yao <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf stat: Zero ena and run for interval mode
Message-ID: <20200409154332.GD3309111@krava>
References: <20200409070755.17261-1-yao.jin@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200409070755.17261-1-yao.jin@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 09, 2020 at 03:07:55PM +0800, Jin Yao wrote:
> As the code comments in perf_stat_process_counter() say,
> we calculate counter's data every interval, and the display
> code shows ps->res_stats avg value. We need to zero the stats
> for interval mode.
> 
> But the current code only zeros the res_stats[0], it doesn't
> zero the res_stats[1] and res_stats[2], which are for ena
> and run of counter.
> 
> This patch zeros the whole res_stats[] for interval mode.
> 
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>

nice catch ;-)

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

> ---
>  tools/perf/util/stat.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
> index 5f26137b8d60..242476eb808c 100644
> --- a/tools/perf/util/stat.c
> +++ b/tools/perf/util/stat.c
> @@ -368,8 +368,10 @@ int perf_stat_process_counter(struct perf_stat_config *config,
>  	 * interval mode, otherwise overall avg running
>  	 * averages will be shown for each interval.
>  	 */
> -	if (config->interval)
> -		init_stats(ps->res_stats);
> +	if (config->interval) {
> +		for (i = 0; i < 3; i++)
> +			init_stats(&ps->res_stats[i]);
> +	}
>  
>  	if (counter->per_pkg)
>  		zero_per_pkg(counter);
> -- 
> 2.17.1
>