Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1869247ybb; Thu, 9 Apr 2020 10:30:16 -0700 (PDT) X-Google-Smtp-Source: APiQypLW7GUDynZW6VNHqNE5xdQ8LtOh3AppasgpOP+/76VaElyvF5tX3kjNg7p3OSvOlEz0yhzz X-Received: by 2002:ac8:6a11:: with SMTP id t17mr408533qtr.195.1586453416205; Thu, 09 Apr 2020 10:30:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586453416; cv=none; d=google.com; s=arc-20160816; b=SOvsEIJrj5sZpM8F1AxFi/CZ+MQlmuNpomKeNNFHQdJ37iyTiJccGkmyTPm172JJEY n0S1eSn2Z5un8iYm5ZDguidTCrgEJYRXEfMwomqAzwfBC2yD8tpCU5SsFZ080ov0osm0 +2nH0V8pkbw3QlkhBokKlzQOfX6PFs1dcIn12LGVgS6jrobcQmU/3uZhXjk/e1hc4q0+ st32xHvsXF9BioxIqUwsow/igJt02g9TfNPyP3rWpCM8v72PxNjBezvp16vF9d22lqOd dz8MZfzGV+3VmfkHBj+gzEcfIuH1jwmh0S4vBwyhg6Zg91QjcPa/KzElv+wjXtZpsrqD yyxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=8L2Hdb0r9Pm8H8J7SLlp+SlgxoDSxAs2w7hBXKbOpDI=; b=UqMqWXyQbod8gigubS5fAX+VQrO9xLt5ufUx9QxgytyITwn3cNY7zq15FqsGM47l0d R5OTEDssoBKLxW4fCEQHxOgo82zzTxJ77OPIiR9PO2ww9qxWNojQCSog4VS6lTgjnmtt NvzYnPZamwYW1xUcbVVPfxpe1+fNKgbyCdb2yzrNQ4ArWE9aglNxEsK+AQPuQ9pHAPGQ 7V3+oetYITlDrnOCXHA+1rsG/w9jzT7M9NAgnDYsreUuMjKhaoin0Y9GdK9/cpjJLdpr WELBHG27FAOLWX8KhS1nRNXhBWpsy0EUj7iVFHQ7SB8gVb5kA8UsoBzAd8epAQOoyOBI mdpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w22si6112166qki.148.2020.04.09.10.30.00; Thu, 09 Apr 2020 10:30:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727933AbgDIQzX (ORCPT + 99 others); Thu, 9 Apr 2020 12:55:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:41166 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727041AbgDIQzX (ORCPT ); Thu, 9 Apr 2020 12:55:23 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DA561AB7F; Thu, 9 Apr 2020 16:55:21 +0000 (UTC) Date: Thu, 9 Apr 2020 18:55:21 +0200 (CEST) From: Miroslav Benes To: Peter Zijlstra cc: Jessica Yu , Josh Poimboeuf , linux-kernel@vger.kernel.org, Thomas Gleixner , keescook@chromium.org Subject: Re: [PATCH] module: Harden STRICT_MODULE_RWX In-Reply-To: Message-ID: References: <20200403163716.GV20730@hirez.programming.kicks-ass.net> <20200403165631.hrxxm3pnzqa4vxln@treble> <20200406104615.GA9629@linux-8ccs> <20200406112732.GK20730@hirez.programming.kicks-ass.net> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I am still wondering if there are modules out there with sections flags > combination which would cause the same problem with layout_sections() and > move_module() logic I described earlier. But that it is a separate issue. And of course I misread the condition in layout_sections() and all should be fine. Oh well... Miroslav