Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200409150210.15488-1-keitasuzuki.park@sslab.ics.keio.ac.jp> <20200409.101844.1655988786538703860.davem@davemloft.net>
In-Reply-To: <20200409.101844.1655988786538703860.davem@davemloft.net>
From:   Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
Date:   Fri, 10 Apr 2020 02:38:35 +0900
Message-ID: <CAEYrHjkjYESXHG1x0Obnz+T5xv00vyZKHzUg=ZC70f0JymSU=g@mail.gmail.com>
Subject: Re: [PATCH] nfp: Fix memory leak in nfp_resource_acquire()
To:     David Miller <davem@davemloft.net>
Cc:     Kubota Takafumi <takafumi.kubota1012@sslab.ics.keio.ac.jp>,
        Jakub Kicinski <kuba@kernel.org>,
        "open list:NETRONOME ETHERNET DRIVERS" <oss-drivers@netronome.com>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

So sorry about this. It seems like I accidentally touched the patch
file after generating / testing the patch.
I will resend the new patch immediately.

I have tested the patch using kmemleak.

Thanks.

2020=E5=B9=B44=E6=9C=8810=E6=97=A5(=E9=87=91) 2:18 David Miller <davem@dave=
mloft.net>:
>
> From: Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
> Date: Thu,  9 Apr 2020 15:02:07 +0000
>
> > This patch fixes a memory leak in nfp_resource_acquire(). res->mutex is
> > alllocated in nfp_resource_try_acquire(). However, when
> > msleep_interruptible() or time_is_before_eq_jiffies() fails, it falls
> > into err_fails path where res is freed, but res->mutex is not.
> >
> > Fix this by changing call to free to nfp_resource_release().
> >
> > Signed-off-by: Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
>
> Did you test compile this?
>
> drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c: In function =
=E2=80=98nfp_resource_acquire=E2=80=99:
> drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c:203:2: error: i=
mplicit declaration of function =E2=80=98nfp_resource_relase=E2=80=99; did =
you mean =E2=80=98nfp_resource_release=E2=80=99? [-Werror=3Dimplicit-functi=
on-declaration]
>   nfp_resource_relase(res);
>   ^~~~~~~~~~~~~~~~~~~
>   nfp_resource_release
>
> And this makes me feel like the test was not runtime tested either.