Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1908018ybb; Thu, 9 Apr 2020 11:14:15 -0700 (PDT) X-Google-Smtp-Source: APiQypId4pFn0o5ogZtHGVOxQ6qq/6NjfRkIE54NalKo39Dv4Dq7YYRdr3Kne4JElzgqE9PmTORW X-Received: by 2002:a05:620a:10b1:: with SMTP id h17mr130651qkk.126.1586456055330; Thu, 09 Apr 2020 11:14:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586456055; cv=none; d=google.com; s=arc-20160816; b=jpALd/Gi5rhxIrjrV4OSriianzrKPbS7TkfE05gZ1cM6UVg/cv8GfKYUkdcF5I9zJt zdKaVOOMppW08d6tYh0l1OcaEEMlA9cgAKCWunbgJCYMAJxcvAW1nZvvQX6e4BuofKMU Xd0XT/vg0y1HpgLECWvqLIusj+RAVxCyndOLVSSw6op3wfoADLOXWJe6A3ZvX8zPNjBo POxGdrX2Ex4NucxeyEMi06kqw+CGG2gln/CHLm9QRA+ht5W2brlnRJUYpisfVP+AguI7 W+YPy3ENiAYMVg5lFEMJEdjRUF4nWW5u6hjgWWkq8AHVYr/3gTcgwNtJeRRjjvIRjdhR w+oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:reply-to; bh=TdyvtUm+JaP+UMcxYN7jfdZXrh36GT0u3q7s/oAfa58=; b=j59vus7l0MQqrot9wEogDg3N7F1E0lrLH4MHg536aZYgveW+VtqfCEjS4GNCFnDKhT UoOAuaFu/YUm2KifsN/Hqxpibz2ybqLBm665ozDhxjocft1sL4BT1b5t9FQn/BYg8OUS 3NGLOsc9J4HJ+Mr0acajSzLhUGEJMuoXyB9VwH16BlkFJ35/w/PqiavOnij9QZQNLaZE myq5k5rmVPJf9XRcKeFUBDMDT6078DWJmykaL0qkigokDPFQgFXrVi5fS5+ihJ7I/LOH RjWqX8yT2kPAqLno8BR4JYkhJcUA55Ni/c4laKo4zpb3PIJEuQ7s355dfSOXhc3zYKZM Yupg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b19si5981035qtc.77.2020.04.09.11.13.57; Thu, 09 Apr 2020 11:14:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726654AbgDISLt (ORCPT + 99 others); Thu, 9 Apr 2020 14:11:49 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:44648 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgDISLs (ORCPT ); Thu, 9 Apr 2020 14:11:48 -0400 Received: by mail-lj1-f194.google.com with SMTP id z26so635588ljz.11; Thu, 09 Apr 2020 11:11:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=TdyvtUm+JaP+UMcxYN7jfdZXrh36GT0u3q7s/oAfa58=; b=gwibrzqdI65uI4bEXRNZf2NjvkCcZmloNfXZvgJNGfVpdU/ttf/H1y1ayjEiheKqrY wVVeRo32vtY3blpbb11wIkLCbNV6YK9tdT8MekjyYyG6bg5gIPI6VvQab2Xkas+Z/jeI YnAw8a4SkLzErS0L9QSido0ArMsM/vqgY59kjwBfsJLAkcNhvYHr0NA6Jn50lCAoXkHx c3LGxMxmKf3lmumuOsDCM7Zp7gKwEdnzxjrqIJxGeRa0r40+qA1qBrAl1hDPVCm9/kz9 MzWu/PqK00PWsn1wVJ/eNtmtdBHBeVcOFpsqF/KON57JrvuIayAM0GLLrvvwtGFgx7Aq F7zg== X-Gm-Message-State: AGi0Pub4yaBpDkXblpBooGrx1T8o858/AZFaK4O1848597UpFzm7Shig ze/zi5bod2qVdSYZiJp7/a4= X-Received: by 2002:a05:651c:119b:: with SMTP id w27mr625366ljo.218.1586455907353; Thu, 09 Apr 2020 11:11:47 -0700 (PDT) Received: from [192.168.42.234] ([213.87.131.218]) by smtp.gmail.com with ESMTPSA id j19sm17732013lfe.17.2020.04.09.11.11.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2020 11:11:46 -0700 (PDT) Reply-To: alex.popov@linux.com Subject: Re: [Cocci] Coccinelle rule for CVE-2019-18683 To: Markus Elfring , cocci@systeme.lip6.fr, kernel-hardening@lists.openwall.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Gilles Muller , Hans Verkuil , Jann Horn , Julia Lawall , Kees Cook , Mauro Carvalho Chehab , Michal Marek , Nicolas Palix References: From: Alexander Popov Autocrypt: addr=alex.popov@linux.com; prefer-encrypt=mutual; keydata= mQINBFX15q4BEADZartsIW3sQ9R+9TOuCFRIW+RDCoBWNHhqDLu+Tzf2mZevVSF0D5AMJW4f UB1QigxOuGIeSngfmgLspdYe2Kl8+P8qyfrnBcS4hLFyLGjaP7UVGtpUl7CUxz2Hct3yhsPz ID/rnCSd0Q+3thrJTq44b2kIKqM1swt/F2Er5Bl0B4o5WKx4J9k6Dz7bAMjKD8pHZJnScoP4 dzKPhrytN/iWM01eRZRc1TcIdVsRZC3hcVE6OtFoamaYmePDwWTRhmDtWYngbRDVGe3Tl8bT 7BYN7gv7Ikt7Nq2T2TOfXEQqr9CtidxBNsqFEaajbFvpLDpUPw692+4lUbQ7FL0B1WYLvWkG cVysClEyX3VBSMzIG5eTF0Dng9RqItUxpbD317ihKqYL95jk6eK6XyI8wVOCEa1V3MhtvzUo WGZVkwm9eMVZ05GbhzmT7KHBEBbCkihS+TpVxOgzvuV+heCEaaxIDWY/k8u4tgbrVVk+tIVG 99v1//kNLqd5KuwY1Y2/h2MhRrfxqGz+l/f/qghKh+1iptm6McN//1nNaIbzXQ2Ej34jeWDa xAN1C1OANOyV7mYuYPNDl5c9QrbcNGg3D6gOeGeGiMn11NjbjHae3ipH8MkX7/k8pH5q4Lhh Ra0vtJspeg77CS4b7+WC5jlK3UAKoUja3kGgkCrnfNkvKjrkEwARAQABtCZBbGV4YW5kZXIg UG9wb3YgPGFsZXgucG9wb3ZAbGludXguY29tPokCVwQTAQgAQQIbIwIeAQIXgAULCQgHAwUV CgkICwUWAgMBAAIZARYhBLl2JLAkAVM0bVvWTo4Oneu8fo+qBQJdehKcBQkLRpLuAAoJEI4O neu8fo+qrkgP/jS0EhDnWhIFBnWaUKYWeiwR69DPwCs/lNezOu63vg30O9BViEkWsWwXQA+c SVVTz5f9eB9K2me7G06A3U5AblOJKdoZeNX5GWMdrrGNLVISsa0geXNT95TRnFqE1HOZJiHT NFyw2nv+qQBUHBAKPlk3eL4/Yev/P8w990Aiiv6/RN3IoxqTfSu2tBKdQqdxTjEJ7KLBlQBm 5oMpm/P2Y/gtBiXRvBd7xgv7Y3nShPUDymjBnc+efHFqARw84VQPIG4nqVhIei8gSWps49DX kp6v4wUzUAqFo+eh/ErWmyBNETuufpxZnAljtnKpwmpFCcq9yfcMlyOO9/viKn14grabE7qE 4j3/E60wraHu8uiXJlfXmt0vG16vXb8g5a25Ck09UKkXRGkNTylXsAmRbrBrA3Moqf8QzIk9 p+aVu/vFUs4ywQrFNvn7Qwt2hWctastQJcH3jrrLk7oGLvue5KOThip0SNicnOxVhCqstjYx KEnzZxtna5+rYRg22Zbfg0sCAAEGOWFXjqg3hw400oRxTW7IhiE34Kz1wHQqNif0i5Eor+TS 22r9iF4jUSnk1jaVeRKOXY89KxzxWhnA06m8IvW1VySHoY1ZG6xEZLmbp3OuuFCbleaW07OU 9L8L1Gh1rkAz0Fc9eOR8a2HLVFnemmgAYTJqBks/sB/DD0SuuQINBFX15q4BEACtxRV/pF1P XiGSbTNPlM9z/cElzo/ICCFX+IKg+byRvOMoEgrzQ28ah0N5RXQydBtfjSOMV1IjSb3oc23z oW2J9DefC5b8G1Lx2Tz6VqRFXC5OAxuElaZeoowV1VEJuN3Ittlal0+KnRYY0PqnmLzTXGA9 GYjw/p7l7iME7gLHVOggXIk7MP+O+1tSEf23n+dopQZrkEP2BKSC6ihdU4W8928pApxrX1Lt tv2HOPJKHrcfiqVuFSsb/skaFf4uveAPC4AausUhXQVpXIg8ZnxTZ+MsqlwELv+Vkm/SNEWl n0KMd58gvG3s0bE8H2GTaIO3a0TqNKUY16WgNglRUi0WYb7+CLNrYqteYMQUqX7+bB+NEj/4 8dHw+xxaIHtLXOGxW6zcPGFszaYArjGaYfiTTA1+AKWHRKvD3MJTYIonphy5EuL9EACLKjEF v3CdK5BLkqTGhPfYtE3B/Ix3CUS1Aala0L+8EjXdclVpvHQ5qXHs229EJxfUVf2ucpWNIUdf lgnjyF4B3R3BFWbM4Yv8QbLBvVv1Dc4hZ70QUXy2ZZX8keza2EzPj3apMcDmmbklSwdC5kYG EFT4ap06R2QW+6Nw27jDtbK4QhMEUCHmoOIaS9j0VTU4fR9ZCpVT/ksc2LPMhg3YqNTrnb1v RVNUZvh78zQeCXC2VamSl9DMcwARAQABiQI8BBgBCAAmAhsMFiEEuXYksCQBUzRtW9ZOjg6d 67x+j6oFAl16ErcFCQtGkwkACgkQjg6d67x+j6q7zA/+IsjSKSJypgOImN9LYjeb++7wDjXp qvEpq56oAn21CvtbGus3OcC0hrRtyZ/rC5Qc+S5SPaMRFUaK8S3j1vYC0wZJ99rrmQbcbYMh C2o0k4pSejaINmgyCajVOhUhln4IuwvZke1CLfXe1i3ZtlaIUrxfXqfYpeijfM/JSmliPxwW BRnQRcgS85xpC1pBUMrraxajaVPwu7hCTke03v6bu8zSZlgA1rd9E6KHu2VNS46VzUPjbR77 kO7u6H5PgQPKcuJwQQ+d3qa+5ZeKmoVkc2SuHVrCd1yKtAMmKBoJtSku1evXPwyBzqHFOInk mLMtrWuUhj+wtcnOWxaP+n4ODgUwc/uvyuamo0L2Gp3V5ItdIUDO/7ZpZ/3JxvERF3Yc1md8 5kfflpLzpxyl2fKaRdvxr48ZLv9XLUQ4qNuADDmJArq/+foORAX4BBFWvqZQKe8a9ZMAvGSh uoGUVg4Ks0uC4IeG7iNtd+csmBj5dNf91C7zV4bsKt0JjiJ9a4D85dtCOPmOeNuusK7xaDZc gzBW8J8RW+nUJcTpudX4TC2SGeAOyxnM5O4XJ8yZyDUY334seDRJWtS4wRHxpfYcHKTewR96 IsP1USE+9ndu6lrMXQ3aFsd1n1m1pfa/y8hiqsSYHy7JQ9Iuo9DxysOj22UNOmOE+OYPK48D j3lCqPk= Message-ID: <9a562397-ba60-8979-1453-b88153722803@linux.com> Date: Thu, 9 Apr 2020 21:11:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Markus, thanks for your remarks! On 09.04.2020 11:41, Markus Elfring wrote: > * The source code search pattern can be too generic. > How do you think about to consider additional constraints > for safer data control flow analysis? Could you please elaborate on that? I used 'exists' keyword to find at least one branch that has mutex_unlock+kthread_stop+mutex_lock chain. > * Other operation modes might become helpful. Thanks! I added 'context' mode, it's very good for this purpose. Best regards, Alexander