Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <703440af-031c-16b5-c1ff-54fb4bb5e10c@gmail.com>
In-Reply-To: <703440af-031c-16b5-c1ff-54fb4bb5e10c@gmail.com>
From:   Andrey Vagin <avagin@openvz.org>
Date:   Thu, 9 Apr 2020 12:17:52 -0700
Message-ID: <CANaxB-y0ZB223dQgvxvUHRzkn4f-_B2vTzYxe_mi=o+3SJ4yVw@mail.gmail.com>
Subject: Re: A further though on /proc/PID/timens_offsets
To:     "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc:     Dmitry Safonov <dima@arista.com>,
        Linux API <linux-api@vger.kernel.org>,
        Containers <containers@lists.linux-foundation.org>,
        Dmitry Safonov <0x7f454c46@gmail.com>,
        lkml <linux-kernel@vger.kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Adrian Reber <adrian@lisas.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 7, 2020 at 6:24 AM Michael Kerrisk (man-pages)
<mtk.manpages@gmail.com> wrote:

>        The  clock-id  identifies the clock whose offsets are being shown.
>        This field is either 1, for CLOCK_MONOTONIC, or 7, for CLOCK_BOOT‐
>        TIME.
>
> What was the reason for exposing numeric clock IDs in the
> timens_offsets file? In API terms, that seems a little ugly.
>
> I think it would have been much nicer if the clocks were defined
> symbolically in this file. I.e., that reading the file would have
> shown something like
>
> monotonic    x    y
> boottime     x    y
>
> And that records similarly with symbolic clock names could have
> been written to the file. Was there a reason not to do this?

No, there was not except that I haven't thought about this. I agree
that symbolic clock names looks nicer for humans, but numeric clock
IDs are a bit more convenient when we  need to set/read offsets from
code. This interface is in the released kernel, so I think we can't
change the format of the content of this file. But we can add support
of symbolic clock names for setting clock offsets. What do you think?

Thanks,
Andrei