Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751512AbWB0Si1 (ORCPT ); Mon, 27 Feb 2006 13:38:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751510AbWB0Si0 (ORCPT ); Mon, 27 Feb 2006 13:38:26 -0500 Received: from mail.dvmed.net ([216.237.124.58]:39378 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1751493AbWB0Si0 (ORCPT ); Mon, 27 Feb 2006 13:38:26 -0500 Message-ID: <44034713.5080102@pobox.com> Date: Mon, 27 Feb 2006 13:38:11 -0500 From: Jeff Garzik User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929) X-Accept-Language: en-us, en MIME-Version: 1.0 To: pomac@vapor.com CC: Stephen Hemminger , woho@woho.de, Carl-Daniel Hailfinger , Jeff Garzik , netdev@vger.kernel.org, Pavel Volkovitskiy , Linux Kernel Mailing List Subject: Re: [PATCH] Revert sky2 to 0.13a References: <4400FC28.1060705@gmx.net> <200602270003.46353.woho@woho.de> <20060227080042.0cf3f05d@localhost.localdomain> <200602271738.38675.woho@woho.de> <20060227091837.3c214435@localhost.localdomain> <1141064841.23375.36.camel@localhost> In-Reply-To: <1141064841.23375.36.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1995 Lines: 55 Ian Kumlien wrote: > On Mon, 2006-02-27 at 09:18 -0800, Stephen Hemminger wrote: > >>On Mon, 27 Feb 2006 17:38:38 +0100 >>Wolfgang Hoffmann wrote: >> >>>On Monday 27 February 2006 17:00, Stephen Hemminger wrote: >>>2.6.16-rc5 with disable_msi=1 works for me, no hangs seen so far. I rsynced 80 >>>GB of data, thats about 5-10 times more than I typically need to reproduce a >>>hang, so it seems to be solid. For the record: 2.6.16-rc5 with disable_msi=0 >>>does hang. >>> >>>I have not seen the memory trashing others reported, with no version I tested >>>so far. Maybe my scenario is not likely to trigger this, so I can't tell. >>> >>>Unless a fix for msi is at hand, may I suggest for 2.6.16 to revert the msi >>>commit or switch the default to disable_msi=1? >>> >>>I've updated bugzilla #6084 accordingly. >> >>Okay, then what I need is lspci -v of all systems that have the problem, I'll make >>a blacklist (or update PCI quirks). I suspect that MSI doesn't work for any devices >>on these systems, or MSI changes the timing enough to expose existing races. > > > Am i just tired from trying to make XSLT to do something unnatural or is > there something odd going on in msi.c? > > static void msi_set_mask_bit(unsigned int vector, int flag) > { > struct msi_desc *entry; > > entry = (struct msi_desc *)msi_desc[vector]; > if (!entry || !entry->dev || !entry->mask_base) > return; > switch (entry->msi_attrib.type) { > case PCI_CAP_ID_MSI: > { > int pos; <== > u32 mask_bits; > > pos = (long)entry->mask_base; <== > ... Just from the casting it seems a bit bogus, yes... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/