Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2094336ybb; Thu, 9 Apr 2020 15:10:20 -0700 (PDT) X-Google-Smtp-Source: APiQypKoSwPJVgY4mEALf94otlbEyirju6TkWkW32MUthXDpTPHAFY7Xg0wPEqYuQS/l6qUL0ae2 X-Received: by 2002:a05:6214:294:: with SMTP id l20mr2423808qvv.46.1586470220827; Thu, 09 Apr 2020 15:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586470220; cv=none; d=google.com; s=arc-20160816; b=DOnEBrBld/hbeKXZciP71d9W0HIPIVetkb0a3/G9xX0Dl9kjtKu8ukJ7dYv90uH4UJ KaiOyEC369x0CPrs8WI9aMNFSlG75A31t/XWagojJpbJueEspBPR3NsIy+pJUxezvXi1 6BIRboJRN+D+BSDxcFBFGBDXU07LOkGm6dJNI2N2+41RCECDaurx52SqwwibDVau049p DHRzk5LnA7xAJKjQyFBn8uUuLgkHt9fBaJ6uahCxzyNLG1Su/dOM+gpe/sAuAtpfJmlA EZnX0iD5SVLeXIj8/0ZP0JzaNAgjHIZ1yhx/+qeXaOeIqwtqwX8EH3VL9FxJnd71wGfx /rTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=CGEzotVnRaQT7yF2QaJvHPaB3shOSQ3vcyNarTslrC8=; b=VnnuIu+yjQAmEUh8WvxuIc8bBhBko0+N8RrnmiJYGMxqe1PCXxqlZUs0Pv/KHkPA8a i7eYPyldf7/TW3wHu25sS8xmpoxm79MLGRfndHJ1rHL4Plr/vCl5XdwIDj7dRrugxqmS 7tMNwoV9SxA0mbfNSR8Z8K+pVu5I+KJITF8g3Jw7KfWJ5/D/cWHGi/5fjscsw0y3dBC5 bXRVH20jS9QzzJrCp+piHlYBIndxeDVQerZMMQ/QPm5O8WjxU6eg/IKJMsyhoRsz/JjZ ilKkulX3cPNRO4LYMbfNeHVjOp13/fb3qSE63yYQl5Xz6YHC1gT0sZciCkobI9OK3f9O ZQ+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HvapQdcE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d22si222191qkl.211.2020.04.09.15.10.04; Thu, 09 Apr 2020 15:10:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HvapQdcE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726852AbgDIWGb (ORCPT + 99 others); Thu, 9 Apr 2020 18:06:31 -0400 Received: from mail-il1-f196.google.com ([209.85.166.196]:33886 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726797AbgDIWGb (ORCPT ); Thu, 9 Apr 2020 18:06:31 -0400 Received: by mail-il1-f196.google.com with SMTP id t11so260094ils.1 for ; Thu, 09 Apr 2020 15:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CGEzotVnRaQT7yF2QaJvHPaB3shOSQ3vcyNarTslrC8=; b=HvapQdcECFWw/ne9zn+KAqOvO4558LNtGEQ4kL6usWUSXTXPck/iGafSzERuAMrQvZ yHo2ND8PSweIBvCw6iuIeTZWayhtPOQNMfxxVRsO2yfJCRWh1ZFyhUBtcD4lEJhecHHH s/we+ObvnqCd2SjrfkaiF1WCL84JcFvVdq2ubrUvA7lYMp1m+dTJwoKF+XRh6ePzi/3y 3sL+QirO5q4RGTYAHyG90pflJN/QM8ZeSjJdCwklBzgiPAWPnc14XKcDdXFSup5OgIyC Gdy9vIMCbc/Gb3XbVAoA5toHp+AbOnY6TyyN+KciMcgyTVh6NH7ZPg4sanYeV0C+/DU5 BJUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CGEzotVnRaQT7yF2QaJvHPaB3shOSQ3vcyNarTslrC8=; b=AAueDYO/U8GUjMXkIsUuyKd5AsVEw5239Byk8VR7eF/TijpsDxbU5dIptbrNWMwz7V czKrLPthR6nBliiTJK6hkl6+9Am/7feinW6BZcYlSirtxA705BmSGY+ToUGRwJuL89qu BqsN+Rv2rLDBHUDOzMCYyi+eGAYhVAYrPPWJFrKjevndY0ckVxrmvSJcQ9TO0ezuxblu 87m+Az339SGceHjdINRTIbxSpvKDD99n3WQSeJ5sT7xzyTQ2V/5/7UJZ3poVJd3rN1T4 AvEtfbNnR5QyQ2OQ5+x6lDPys3SqjZGo42OF71pGiLo/EVpslUp04i84MGu1305MKhYB Ltzw== X-Gm-Message-State: AGi0Pubn6XH0hMETx+DyrdV7JkdLBgfPDc6hsAooAdg2qb8V7202HAUM 316uBQ4zYKUI9QsBc4sz3p8Yz2aGnQrVWFxKkEk= X-Received: by 2002:a92:d407:: with SMTP id q7mr2019917ilm.95.1586469988954; Thu, 09 Apr 2020 15:06:28 -0700 (PDT) MIME-Version: 1.0 References: <20200406172525.GA338360@carbon.DHCP.thefacebook.com> In-Reply-To: <20200406172525.GA338360@carbon.DHCP.thefacebook.com> From: Yang Li Date: Thu, 9 Apr 2020 17:06:17 -0500 Message-ID: Subject: Re: mm/hugetlb.c:5580:3: error: implicit declaration of function 'for_each_mem_pfn_range'; did you mean 'for_each_mem_range' To: Roman Gushchin Cc: Naresh Kamboju , Andrew Morton , open list , andreas.schaufler@gmx.de, "Kirill A. Shutemov" , Mike Kravetz , Michal Hocko , Rik van Riel , js1304@gmail.com, lkft-triage@lists.linaro.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 6, 2020 at 12:37 PM Roman Gushchin wrote: > > On Mon, Apr 06, 2020 at 07:48:54PM +0530, Naresh Kamboju wrote: > > While building Linux-next master for arm beagle board x15 the following > > build error was noticed. > > Hello Naresh! > > There was a number of cleanups and fixes to the original hugetlb_cma > patch, and it looks like some parts were lost. > I'm going to gather all changes and resubmit a new version later today. > Sorry for the inconvenience. Hi Roman, I'm still getting this compile issue with linux-next tag next-20200409. If the current patch set is broken, can we remove them from the linux-next for now? Regards, Leo > > Thanks! > > > > > mm/hugetlb.c: In function 'hugetlb_cma_reserve': > > mm/hugetlb.c:5580:3: error: implicit declaration of function > > 'for_each_mem_pfn_range'; did you mean 'for_each_mem_range'? > > [-Werror=3Dimplicit-function-declaration] > > for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL) { > > ^~~~~~~~~~~~~~~~~~~~~~ > > for_each_mem_range > > mm/hugetlb.c:5580:62: error: expected ';' before '{' token > > for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL) { > > ^ > > Few more details about build test, > > > > CONFIG_HUGETLBFS=3Dy > > CONFIG_HUGETLB_PAGE=3Dy > > CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE=3Dy > > CONFIG_ARCH_WANT_HUGE_PMD_SHARE=3Dy > > > > # CONFIG_TRANSPARENT_HUGEPAGE is not set > > # CONFIG_CMA is not set > > > > Kernel config link, > > https://urldefense.proofpoint.com/v2/url?u=3Dhttp-3A__snapshots.linaro.= org_openembedded_lkft_lkft_sumo_intel-2Dcore2-2D32_lkft_linux-2Dmainline_25= 91_config&d=3DDwIBaQ&c=3D5VD0RTtNlTh3ycd41b3MUw&r=3DjJYgtDM7QT-W-Fz_d29HYQ&= m=3DUExtNmMVvgxP1D5SQnPuvrZmT1KYfONSBf9zENyfrs4&s=3DO436GE4UqAvqVk0stawAOhO= Um1bNCFpZzxiVeNSs-ck&e=3D > > > > Build log, > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__ci.linaro.org_vi= ew_lkft_job_openembedded-2Dlkft-2Dlinux-2Dnext_DISTRO-3Dlkft-2CMACHINE-3Dam= 57xx-2Devm-2Clabel-3Ddocker-2Dlkft_743_consoleText&d=3DDwIBaQ&c=3D5VD0RTtNl= Th3ycd41b3MUw&r=3DjJYgtDM7QT-W-Fz_d29HYQ&m=3DUExtNmMVvgxP1D5SQnPuvrZmT1KYfO= NSBf9zENyfrs4&s=3DnuGZRu4xyY-99ohWh1uNDTo6NeV62n7kSsyoefxEGvI&e=3D > > > > -- > > Linaro LKFT > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__lkft.linaro.org&= d=3DDwIBaQ&c=3D5VD0RTtNlTh3ycd41b3MUw&r=3DjJYgtDM7QT-W-Fz_d29HYQ&m=3DUExtNm= MVvgxP1D5SQnPuvrZmT1KYfONSBf9zENyfrs4&s=3DuYemxk7TXD2Qie6H7zY9UjuE7zlN5ILjb= D_1UD3jo4A&e=3D --=20 - Leo