Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2095850ybb; Thu, 9 Apr 2020 15:12:03 -0700 (PDT) X-Google-Smtp-Source: APiQypIDWkRjafg9vrCYFYfg/Q/ZblgofMVmuYf0ZhBc8FVZp7dtKUttOnOrHxIWbazdsGUtaGt1 X-Received: by 2002:ac8:72d7:: with SMTP id o23mr1650509qtp.101.1586470323155; Thu, 09 Apr 2020 15:12:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586470323; cv=none; d=google.com; s=arc-20160816; b=NSDdIrrEmZO4I13hT3RB7UA9j4+eC4tBgqAMDfxcNUUTDgELADT1ErqmTf8i0Y/zEC y7A/7lMqrw+bJAVGhOkxI+1RfKxR3PrNRmsfEohN7txYbkw0J99ZeavJr01S9vlVgY0m yZsfY9fjIo8agXHIhA9cOVxAb4j0QD158cSa763+FzR3g3G5Kq1XZ3cjpVfxYdcd7d7i lmJ5kP/M+3zTWgxode0DEyXbzUfrfv/PzTNhcZDmH88+o4Rh5Wf0zcPp2xOH8pWDkHhF q5tYrDOhGzAFd6KTCBcYXjDy0ym4vQZ5MlMIMJTwFbFRTAj4fKf+B5AJiEeJInBl1t7I KfkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=d0YWsJp6o5xV2UL2uS6Ygl+hmCi+0Eyl441GMe3mK+4=; b=yihial7VgwLYm/GEbGjHFXuJEiRalqYwOk3u7J0Jn0LUn1q1nwtzVIjzWbVyXVm8uL jub9eqAqcOYW9/K5R66TqXZCgtFCucVwwQOB+TDcxMajCaQyLB2Zs0stujGFQJuRRMEG GBIhCysdGfoel9P217LNYyk2DHMU0bjaHSlI0zpLz1FMzLTE+X3MkfiJbiHvjcDdceiI C0KwqMZy7XKX5dDHAQAxvJNhhVAr45p458IcLwUzDkauBXpvogozHDSJGN/45cE+VlbE fwRMfRWB/GmuEQ14n+0BOk17QzaU6wtixN5HvJOfBjSf6DDpFzg4kcAVTvZADWIF5UzP h7Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RWFHgXcA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i19si3431766qvm.184.2020.04.09.15.11.47; Thu, 09 Apr 2020 15:12:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RWFHgXcA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726945AbgDIWJV (ORCPT + 99 others); Thu, 9 Apr 2020 18:09:21 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:27115 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726713AbgDIWJV (ORCPT ); Thu, 9 Apr 2020 18:09:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586470160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=d0YWsJp6o5xV2UL2uS6Ygl+hmCi+0Eyl441GMe3mK+4=; b=RWFHgXcAGp5D+FvzAq++KyZR7mp8T7f/a3kqnWF7LrlucDHbL/imgjyMtjLdldjizFSjcs XBc3aLa3691AdCmlbrBOvJzHxMeq5wwicWCSoriUnEBynCsG8Ploi1hLcNXdeYa1PpNZER vNfiJEkxMhnYZJYoxlRuAfU0MLIgaqc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-GMJ2DFMMM52FoRdkcOgzgg-1; Thu, 09 Apr 2020 18:09:15 -0400 X-MC-Unique: GMJ2DFMMM52FoRdkcOgzgg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B06421007268; Thu, 9 Apr 2020 22:09:14 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-15.gru2.redhat.com [10.97.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 983379D348; Thu, 9 Apr 2020 22:09:08 +0000 (UTC) From: Wainer dos Santos Moschetta To: pbonzini@redhat.com, kvm@vger.kernel.org Cc: drjones@redhat.com, david@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, krish.sadhukhan@oracle.com Subject: [PATCH v5 0/2] selftests: kvm: Introduce the mem_slot_test test Date: Thu, 9 Apr 2020 19:09:03 -0300 Message-Id: <20200409220905.26573-1-wainersm@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series introduces a new KVM selftest (mem_slot_test) that goal is to verify memory slots can be added up to the maximum allowed. An extra slot is attempted which should occur on error. The patch 01 is needed so that the VM fd can be accessed from the test code (for the ioctl call attempting to add an extra slot). I ran the test successfully on x86_64, aarch64, and s390x. This is why it is enabled to build on those arches. - Changelog - v4 -> v5: - Initialize the guest_addr and mem_reg_size variables on definition [krish.sadhukhan] v3 -> v4: - Discarded mem_reg_flags variable. Simply using 0 instead [drjones] - Discarded kvm_region pointer. Instead passing a compound literal in the ioctl [drjones] - All variables are declared on the declaration block [drjones] v2 -> v3: - Keep alphabetical order of .gitignore and Makefile [drjones] - Use memory region flags equals to zero [drjones] - Changed mmap() assert from 'mem != NULL' to 'mem != MAP_FAILED' [drjones] - kvm_region is declared along side other variables and malloc()'ed later [drjones] - Combined two asserts into a single 'ret == -1 && errno == EINVAL' [drjones] v1 -> v2: - Rebased to queue - vm_get_fd() returns int instead of unsigned int (patch 01) [drjones] - Removed MEM_REG_FLAGS and GUEST_VM_MODE defines [drjones] - Replaced DEBUG() with pr_info() [drjones] - Calculate number of guest pages with vm_calc_num_guest_pages() [drjones] - Using memory region of 1 MB sized (matches mininum needed for s390x) - Removed the increment of guest_addr after the loop [drjones] - Added assert for the errno when adding a slot beyond-the-limit [drjones] - Prefer KVM_MEM_READONLY flag but on s390x it switch to KVM_MEM_LOG_DIRTY_PAGES, so ensure the coverage of both flags. Also somewhat tests the KVM_CAP_READONLY_MEM capability check [drjones] - Moved the test logic to test_add_max_slots(), this allows to more easily add new cases in the "suite". v1: https://lore.kernel.org/kvm/20200330204310.21736-1-wainersm@redhat.com Wainer dos Santos Moschetta (2): selftests: kvm: Add vm_get_fd() in kvm_util selftests: kvm: Add mem_slot_test test tools/testing/selftests/kvm/.gitignore | 1 + tools/testing/selftests/kvm/Makefile | 3 + .../testing/selftests/kvm/include/kvm_util.h | 1 + tools/testing/selftests/kvm/lib/kvm_util.c | 5 ++ tools/testing/selftests/kvm/mem_slot_test.c | 69 +++++++++++++++++++ 5 files changed, 79 insertions(+) create mode 100644 tools/testing/selftests/kvm/mem_slot_test.c -- 2.17.2