Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2116280ybb; Thu, 9 Apr 2020 15:38:19 -0700 (PDT) X-Google-Smtp-Source: APiQypJz6lPNfKaNI4pdFD4dGFXTSgUq4TBaEVcwD13Z+na61coQPZXG3Z6diBMX2IYE5BAcm7b0 X-Received: by 2002:ae9:ef93:: with SMTP id d141mr1239596qkg.311.1586471899106; Thu, 09 Apr 2020 15:38:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586471899; cv=none; d=google.com; s=arc-20160816; b=g5VykZs9UeoAjEED13tdz9Bpc3OW20/luYVhtViiUBYxSsmHwpol69koFp2bGwB+X3 lhuLXrnrdkqWkMEtOWwFC7XWjfV2diS7FINK/pe+uxP2XfbneDAuz46GhdClDH6X2P5v 0m//CdF3cyoPeTVssIWpjkKXColpetl/YHW6XfoukhzcqnaOXktn8AEtrOVetIsb/zod usPx13oRVNczOZFF7az8YQ3Lmw5Yqsel5WaNqQb/pIMfCgQa+87plPyPIfC+iS5IVzBa 0PQOz/sYOgHsXwLmyWsVRSUV1NIJaiRwm1kz4mdt+C8wE62JbzcMbApISmV3Imv2DQKE bFdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :ironport-sdr:ironport-sdr; bh=Vq0538R1KSsV9mgCPFbOu4eOV3x5jWw0hKczigTayBU=; b=WjV3faO3i4LUJb1aFmbpJp68x8Dk3yvNJprOazecBbQLCMo6x4oNkWt3B/mSRv01tO F7uEuqIaiZ3bEJgXUP1oz1tVd5G5NScgnNzTS3I4Vzbhu6KJk6JiwdnYLfDC/uJQSxsU RxcrSh5QgLTYaFiAawkQQUlMmL8LmiXk3ORvuvv87zugFyzpNEiOs31eFFj8MT9bkC2b F1sjgmkL2mm+HfBwTC+dQP3JQRWcgu1m+wpB9YwAxzWvzuaIFxXcOr8XLA0MoCKkiDTg 2cTdIAFOBtDDiGVomjKFhpCoOWZGwrZOVxlJnC0JpmD77+D7N56/pMsYWvJ1A5AR9gID +ufg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i1si79889qtq.179.2020.04.09.15.38.03; Thu, 09 Apr 2020 15:38:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726892AbgDIWfK (ORCPT + 99 others); Thu, 9 Apr 2020 18:35:10 -0400 Received: from mga07.intel.com ([134.134.136.100]:15355 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbgDIWfK (ORCPT ); Thu, 9 Apr 2020 18:35:10 -0400 IronPort-SDR: b3ypxeG+isAe/o6tm9HCUY5mLNEUHCFphw36EOU1BMLCATVGcDAk4xyJQzibIeEIwLsxbPpUZQ 0vtZXbYGtvTQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 15:35:09 -0700 IronPort-SDR: oLSeoNPXuAr7W5ylj3qjb7z8SiJDYW1ZhdU8AwMSEVMnfVuQPM0nVnLhNiaI9LDn3Z75+8JDAT PGhfObpqSBZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,364,1580803200"; d="scan'208";a="255301786" Received: from jmmonter-mobl1.amr.corp.intel.com (HELO [10.255.230.75]) ([10.255.230.75]) by orsmga006.jf.intel.com with ESMTP; 09 Apr 2020 15:35:07 -0700 Subject: Re: [PATCH] x86/mm/init: Stop printing pgt_buf addresses To: Arvind Sankar Cc: "Tobin C . Harding" , Tycho Andersen , kernel-hardening@lists.openwall.com, Kees Cook , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org References: <20200229231120.1147527-1-nivedita@alum.mit.edu> <20200409221919.GA1460035@rani.riverdale.lan> From: Dave Hansen Openpgp: preference=signencrypt Autocrypt: addr=dave.hansen@intel.com; keydata= mQINBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABtEVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT6JAjgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lcuQINBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABiQIfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y Message-ID: Date: Thu, 9 Apr 2020 15:35:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20200409221919.GA1460035@rani.riverdale.lan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/9/20 3:19 PM, Arvind Sankar wrote: >> @@ -121,8 +121,6 @@ __ref void *alloc_low_pages(unsigned int num) >> } else { >> pfn = pgt_buf_end; >> pgt_buf_end += num; >> - printk(KERN_DEBUG "BRK [%#010lx, %#010lx] PGTABLE\n", >> - pfn << PAGE_SHIFT, (pgt_buf_end << PAGE_SHIFT) - 1); >> } >> >> for (i = 0; i < num; i++) { >> -- >> 2.24.1 >> > This was acked by Kees, is it ok for merge? Independent of the obvious security implications, I don't think I've ever once gleaned useful information from that message. It's fine by me. Acked-by: Dave Hansen