Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1586468669-21456-1-git-send-email-victor.erminpour@oracle.com>
In-Reply-To: <1586468669-21456-1-git-send-email-victor.erminpour@oracle.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Fri, 10 Apr 2020 10:09:25 +0200
Message-ID: <CAMj1kXGgYYx=9rq-Ficw3vS6FX_0nb-hRStXijh7H4zdD=+Gaw@mail.gmail.com>
Subject: Re: [PATCH] efi/libstub/arm64: Enable __efistub_global define in
 .data section
To:     Victor Erminpour <victor.erminpour@oracle.com>
Cc:     linux-efi <linux-efi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 9 Apr 2020 at 23:44, Victor Erminpour
<victor.erminpour@oracle.com> wrote:
>
> Enable the __efistub_global define to place variables in the
> .data section for both CONFIG_ARM and CONFIG_ARM64.
>
> This places the EFIstub sys_table variable and other EFIstub
> static variables in the .data section for both CONFIG_ARM and
> CONFIG_ARM64.
>

What does that achieve?

> Signed-off-by: Victor Erminpour <victor.erminpour@oracle.com>
> ---
>  drivers/firmware/efi/libstub/efistub.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/efistub.h b/drivers/firmware/efi/libstub/efistub.h
> index c244b16..59932d6 100644
> --- a/drivers/firmware/efi/libstub/efistub.h
> +++ b/drivers/firmware/efi/libstub/efistub.h
> @@ -25,7 +25,7 @@
>  #define EFI_ALLOC_ALIGN                EFI_PAGE_SIZE
>  #endif
>
> -#ifdef CONFIG_ARM
> +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
>  #define __efistub_global       __section(.data)
>  #else
>  #define __efistub_global