Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp467699ybb; Fri, 10 Apr 2020 03:50:48 -0700 (PDT) X-Google-Smtp-Source: APiQypLouAKSa6NiCc74/M2Nlfe4XqX2OW4/mfC0GPqw3LIJY4yMfIaqqhRDt+za3KSeKkV3rmMk X-Received: by 2002:a05:620a:1095:: with SMTP id g21mr3334220qkk.476.1586515848237; Fri, 10 Apr 2020 03:50:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586515848; cv=none; d=google.com; s=arc-20160816; b=mE8aihBSRFPqw2424etrrOGl01nnKUxgFGcJW2K9D7+hvWZiMCywtoUZ+vdOatJt/k zp4EIM2EJ+4kP68thSmw3qM6z3pI1gpYtZtMoihHuHBar/HpTiGNXdPyVH19ZPXEcavd gTCMbz7pdwLXbHOxYYm3qTgolSz8IsCcCm1CymZWSGUXbWB6YgPis8zXvUddBCukVodP TkAXkxwxkiPUHFYNeHY9ExCU8afSJQJ+BXgvHXE46rNFzlpUp+sfw/boppRUUhFW0e1c NNkhUiwMhoTZVlY+StxEnz5uPsj69FYVQAVWCJ256o19PVHojwh1rvx3n+OlnjgOr+qb Xwew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Atf0UBsusl8Nwd2Z4EGpQkAq0RXvQRuBtcNToI2mGqw=; b=wZGnPIzpBoYniJVivQQ6d+9qUdy5rhYBRGPJo/6dJ6oiNHUne8Lx/1vYKA3RyFy7TJ k+AEEjzdmDu/iIM9j84WaxItnU+ChT6fb3JPl+uGcRKKQxBdTU1a09I/zmq3JMAf8idd 0Jdma5X5FP+9J69gA6UoDUibaRtXdXazPBhQBZSpG6q02cPhGggUBobzcPNJD0e66mfU P9elDhIZhx8vLurYE0I1rQkFbRbqoNugEOs9jSwWoguuu03iyqqV06+RgnCeudcvGj7R zaCEZDIAVhH9QEzEktWFd+zM1Zm8AypOY4X9myPcLup8QTQHTlrkPUoH+9XwDCAoyyDk f7Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e9si920642qta.199.2020.04.10.03.50.33; Fri, 10 Apr 2020 03:50:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726141AbgDJKsk (ORCPT + 99 others); Fri, 10 Apr 2020 06:48:40 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:43968 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbgDJKsj (ORCPT ); Fri, 10 Apr 2020 06:48:39 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 85414FB03; Fri, 10 Apr 2020 12:48:37 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bW2A5ldcPbjn; Fri, 10 Apr 2020 12:48:36 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id ECBD840601; Fri, 10 Apr 2020 12:48:35 +0200 (CEST) Date: Fri, 10 Apr 2020 12:48:35 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Sam Ravnborg Cc: David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Lee Jones , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Robert Chiras , Arnd Bergmann Subject: Re: [PATCH v11 0/2] drm: bridge: Add NWL MIPI DSI host controller support Message-ID: <20200410104835.GA22010@bogon.m.sigxcpu.org> References: <20200409140130.GA11188@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200409140130.GA11188@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Apr 09, 2020 at 04:01:30PM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Thu, Apr 09, 2020 at 12:42:00PM +0200, Guido G?nther wrote: > > This adds initial support for the NWL MIPI DSI Host controller found on i.MX8 > > SoCs. > > > > It adds support for the i.MX8MQ but the same IP core can also be found on e.g. > > i.MX8QXP. I added the necessary hooks to support other imx8 variants but since > > I only have imx8mq boards to test I omitted the platform data for other SoCs. > > > > The code is based on NXPs BSP so I added Robert Chiras as Co-authored-by. > > > > The most notable changes over the BSP driver are > > - Calculate HS mode timing from phy_configure_opts_mipi_dphy > > - Perform all clock setup via DT > > - Merge nwl-imx and nwl drivers > > - Add B0 silion revision quirk > > - become a bridge driver to hook into mxsfb / dcss > > imx-display-subsystem so it makes sense to make it drive a bridge for dsi as > > well). > > - Use panel_bridge to attach the panel > > - Use multiplex framework instead of accessing syscon directly > > > > This has been tested on a Librem 5 devkit using mxsfb with Robert's patches[1] > > and the mainline rocktech-jh057n00900 DSI panel driver on next-20200317 and on > > the Librem5 with the a Mantix MLAF057WE51-X DSI panel driver (not yet mainline) > > The DCSS (submitted for mainline inclusion now too) can also act as input > > source. > > Thanks for your persistence with this driver. > I got ack from Laurent on IRC to apply it (not for the driver as he had > no time to review it). > So applied to drm-misc-next now. > > I look forward for the update to support DRM_BRIDGE_ATTACH_NO_CONNECTOR > in this driver and the corresponding display driver. Thanks. I'll have a look at that (currently checking where the larger mxsfb rework of Laurent is going so i can use that as a base eventually). Cheers, -- Guido