Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp471708ybb; Fri, 10 Apr 2020 03:56:41 -0700 (PDT) X-Google-Smtp-Source: APiQypLFkvzgiCIEkvxdjOS61g1Y+cWW4PzW6k0R+Ep69XDyV1vjekxpO/MunwVnx185Ls0XSn7j X-Received: by 2002:a37:aec2:: with SMTP id x185mr3518385qke.45.1586516201297; Fri, 10 Apr 2020 03:56:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586516201; cv=none; d=google.com; s=arc-20160816; b=SGXCb7Ee4Dm0bVKKDFwDqZ0ZKF9T2iOh+zj2SpeVXvwJKOt6q0an//W+8ZCAKAmRt3 Ko6EXPxdpgT853c+VmfPIVdaOd/kb+YqFTdsqLSvu7Xsgtft9YnIl1Qb+84ejLrZ7sYd /kxE1lIFPtSf7JA/k3VvSYYjK3gNuhc7ZR1Kxr2Ec1mKrpIsTVmoCBt3dtMMX6onJu40 AE65nETAKFiM3BBjcoohdz7W/kArqFksSHU1ICK1yK3CzKbBFWxL3DMIIh9Nol+gm5Um Jx01D6tsUJB5PS8QK/HWZ32QXblu9IEf05QTgYSC9dCQ2NSy/rNVxGX6Y43ODIDj+vIE KBpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=aIcnFNlKwbhEUKuern25WOvqQEVVsTXqGIr0A8WwShs=; b=zMO/rht29jN0G2B16DjSPpqy5Ych8iDfBbO87qWm++l4cCSBhpWHFBMUISGbnu5iJ5 uKiTJCUUZg1eS6fuRyJtGij3iC/YV94iPv7jlFHJQ1CeZ4/HBTPKKkP+5E/D76nLBm2w cF+xmZNA9UXiU1SNgZh/jfv1NoUh2FdG5m08w/xE4gwcFxNq08euuMtkrkZn2a2JyLPS fwvFy2r7zYx01DJKzVmDP6kXoWzwLnqn+aHpf34tKgt9YfPFPEz4w6h3WaMqEcJx31c6 tHI8tyKg5CSyp4ZDrvpBgEDbk/Sik/eCPmKYmBRcnOdwrZPe6+SV6sv60HqxZ+5T30KM WD1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OHsTaGa0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a12si814963qvb.198.2020.04.10.03.56.25; Fri, 10 Apr 2020 03:56:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OHsTaGa0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726059AbgDJKzi (ORCPT + 99 others); Fri, 10 Apr 2020 06:55:38 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:33568 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725924AbgDJKzi (ORCPT ); Fri, 10 Apr 2020 06:55:38 -0400 Received: by mail-pg1-f195.google.com with SMTP id d17so864839pgo.0; Fri, 10 Apr 2020 03:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aIcnFNlKwbhEUKuern25WOvqQEVVsTXqGIr0A8WwShs=; b=OHsTaGa0WQ0YKhuVGOQ6pPcIKYKJQmtrS2+T8Szuyi16vomvG6C+YQ0O3IlqEnYEuY vu9zRhcCwSVWKFUOlCa+2e9JI8Q6x940HHClWPfwkcZnMF5hnXZKbD0oS6/aaG+TnVYc pRBFg5mAzqvql2AcdtPhjL9lMpMJ9J2zqmyzybRd0MWTbak6q6rP9UheTARiDh2qHMmB OQLbxh7glsMqwXOzDPqJ8GoCU7fjGbJFO+iSiVuKbM6+M63B4ffbioe7km4BzU/PYU9j hGP5CFwcd6r6oL55/u1/wjFFN6GAWEnYsAY8JBGSBgVtGEPYEMk727gMMDVvVW+2vJC+ YoRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aIcnFNlKwbhEUKuern25WOvqQEVVsTXqGIr0A8WwShs=; b=FQGoLlD1OjYCfqSugyQ6xskZ0/oMm0SQifUxR0KCy9nLSx5UnR59xAtP8+DArMKqxS Vo1UMwWuFZVW3nwZrfu3CB9oFdhEaNzyxGD5jUS9XZjScMpU7e+gmE97IhHQLN8QPXOs Eh9vkMsE/v1IcasF+GGfWlFLg6dWXlMOhKraT12WzO1rmwZQI9FNgeTaj8N1+VxZ0pbW R5AYpZLftXljP/nscrZYDrvWhGQmjsTFiiZ6IeXtCti94Sr3Cen9K30px+tpeHXlIGr2 bATAOfUW5L0BdSEEpWwfaxGlUmIaR2+wPPOmYZdPg446IYwtEY6yjrBjFwurfg5LgAOH k1vw== X-Gm-Message-State: AGi0Puak9eMKhODsor6zaLp9Wbw8eZ50XdlnsM4RcQurMJv+idfhK/1w BtrC+Ip0DepZegzPSFm1mIs4o5TmVFfqFRKG0dU= X-Received: by 2002:aa7:958f:: with SMTP id z15mr4357812pfj.130.1586516137980; Fri, 10 Apr 2020 03:55:37 -0700 (PDT) MIME-Version: 1.0 References: <20200409151125.32677-1-aishwaryarj100@gmail.com> <20200409155936.GV3628@piout.net> In-Reply-To: <20200409155936.GV3628@piout.net> From: Andy Shevchenko Date: Fri, 10 Apr 2020 13:55:26 +0300 Message-ID: Subject: Re: [PATCH] iio: adc: at91-adc: Use devm_platform_ioremap_resource To: Alexandre Belloni Cc: Aishwarya R , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Nicolas Ferre , Ludovic Desroches , Thomas Gleixner , Allison Randal , Kefeng Wang , Stephen Boyd , linux-iio , linux-arm Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 9, 2020 at 7:00 PM Alexandre Belloni wrote: > On 09/04/2020 20:41:23+0530, Aishwarya R wrote: > > Use the helper function that wraps the calls to > > platform_get_resource() and devm_ioremap_resource() > > together. > Please elaborate the actual value of doing that. Please, elaborate actual value of not doing that. Yes, I know that you are p* off of these changes, but why you not going further and forbid all clean ups we are doing in the code? To the point. Above change is reducing code base and showing the new comers modern APIs to use. -- With Best Regards, Andy Shevchenko