Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 10 Apr 2020 14:47:39 +0300
From:   "Kirill A. Shutemov" <kirill@shutemov.name>
To:     Zi Yan <ziy@nvidia.com>
Cc:     akpm@linux-foundation.org, Andrea Arcangeli <aarcange@redhat.com>,
        Yang Shi <yang.shi@linux.alibaba.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCHv2 1/8] khugepaged: Add self test
Message-ID: <20200410114739.b2ndracbyhsdmanv@box>
References: <20200403112928.19742-1-kirill.shutemov@linux.intel.com>
 <20200403112928.19742-2-kirill.shutemov@linux.intel.com>
 <D55D6A3A-47A1-41F5-B939-36EEA740CF72@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <D55D6A3A-47A1-41F5-B939-36EEA740CF72@nvidia.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 06, 2020 at 10:59:52AM -0400, Zi Yan wrote:
> I ran this test with all patches from this series applied to Linus’s tree, but still see several failures. Is it expected?
> The config file is attached. Let me know if I miss anything. BTW, I am running in a VM.
> 
> Thanks.
> 
> The output:
> 
> ➜  ~ sudo ./khugepaged
> Save THP and khugepaged settings... OK
> Adjust settings... OK
> Allocate huge page on fault... OK
> Split huge PMD on MADV_DONTNEED... OK
> Collapse fully populated PTE table.... Fail

I was able to reproduce the issue. And it's fun failure mode.

How did you get the test case inside the VM? Copy-paste source using 'cat'
or something similar inside the VM?

It screwed up CHECK_HUGE_FMT and CHECK_SWAP_FMT for me. Double back slash
was converted to single. As result check_huge() and check_swap() gave the
false-negative result all the time.

Could you check that the source of the test-case is not mangled and
re-test if it is.

-- 
 Kirill A. Shutemov