Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <fb784ea2a4b3d4219a4e2604beee0b15cb2275b4.camel@kernel.org>
Subject: Re: [PATCH] tracing: make some symbols static in tracing_map.c
From:   Tom Zanussi <zanussi@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>,
        Jason Yan <yanaijie@huawei.com>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org
Date:   Fri, 10 Apr 2020 08:55:55 -0500
In-Reply-To: <20200410094427.1f1ede4d@gandalf.local.home>
References: <20200410073312.38855-1-yanaijie@huawei.com>
         <20200410094427.1f1ede4d@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2020-04-10 at 09:44 -0400, Steven Rostedt wrote:
> Tom,
> 
> Care to ack this?
> 

Sure,

Reviewed-by: Tom Zanussi <zanussi@kernel.org>

Tom


> -- Steve
> 
> 
> On Fri, 10 Apr 2020 15:33:12 +0800
> Jason Yan <yanaijie@huawei.com> wrote:
> 
> > Fix the following sparse warning:
> > 
> > kernel/trace/tracing_map.c:286:6: warning: symbol
> > 'tracing_map_array_clear' was not declared. Should it be static?
> > kernel/trace/tracing_map.c:297:6: warning: symbol
> > 'tracing_map_array_free' was not declared. Should it be static?
> > kernel/trace/tracing_map.c:319:26: warning: symbol
> > 'tracing_map_array_alloc' was not declared. Should it be static?
> > 
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Jason Yan <yanaijie@huawei.com>
> > ---
> >  kernel/trace/tracing_map.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/kernel/trace/tracing_map.c
> > b/kernel/trace/tracing_map.c
> > index 9e31bfc818ff..74738c9856f1 100644
> > --- a/kernel/trace/tracing_map.c
> > +++ b/kernel/trace/tracing_map.c
> > @@ -283,7 +283,7 @@ int tracing_map_add_key_field(struct
> > tracing_map *map,
> >  	return idx;
> >  }
> >  
> > -void tracing_map_array_clear(struct tracing_map_array *a)
> > +static void tracing_map_array_clear(struct tracing_map_array *a)
> >  {
> >  	unsigned int i;
> >  
> > @@ -294,7 +294,7 @@ void tracing_map_array_clear(struct
> > tracing_map_array *a)
> >  		memset(a->pages[i], 0, PAGE_SIZE);
> >  }
> >  
> > -void tracing_map_array_free(struct tracing_map_array *a)
> > +static void tracing_map_array_free(struct tracing_map_array *a)
> >  {
> >  	unsigned int i;
> >  
> > @@ -316,7 +316,7 @@ void tracing_map_array_free(struct
> > tracing_map_array *a)
> >  	kfree(a);
> >  }
> >  
> > -struct tracing_map_array *tracing_map_array_alloc(unsigned int
> > n_elts,
> > +static struct tracing_map_array *tracing_map_array_alloc(unsigned
> > int n_elts,
> >  						  unsigned int
> > entry_size)
> >  {
> >  	struct tracing_map_array *a;
> 
>