Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 10 Apr 2020 18:45:33 +0200
From:   David Sterba <dsterba@suse.cz>
To:     Eugene Syromiatnikov <esyr@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
        David Sterba <dsterba@suse.com>,
        Nikolay Borisov <nborisov@suse.com>,
        Josef Bacik <josef@toxicpanda.com>, Chris Mason <clm@fb.com>,
        "Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH] btrfs: re-instantiate the removed
 BTRFS_SUBVOL_CREATE_ASYNC definition
Message-ID: <20200410164533.GP5920@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Eugene Syromiatnikov <esyr@redhat.com>,
        linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
        David Sterba <dsterba@suse.com>,
        Nikolay Borisov <nborisov@suse.com>,
        Josef Bacik <josef@toxicpanda.com>, Chris Mason <clm@fb.com>,
        "Dmitry V. Levin" <ldv@altlinux.org>
References: <20200401032650.GA24378@asgard.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200401032650.GA24378@asgard.redhat.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 01, 2020 at 05:26:50AM +0200, Eugene Syromiatnikov wrote:
> The commit 9c1036fdb1d1ff1b ("btrfs: Remove BTRFS_SUBVOL_CREATE_ASYNC
> support") breaks strace build with the kernel headers from git:
> 
>     btrfs.c: In function "btrfs_test_subvol_ioctls":
>     btrfs.c:531:23: error: "BTRFS_SUBVOL_CREATE_ASYNC" undeclared (first use
>     in this function)
>        vol_args_v2.flags = BTRFS_SUBVOL_CREATE_ASYNC;
> 
> Moreover, it is improper to break UAPI anyway.

IIRC the reason for the UAPI exports was to let strace use the includes
to decode the ioctls, so for that I agree it's improper to break the
build, sorry. The ioctls are a public interface so it's an ABI.  Patch
added to 5.7 queue, thanks.