Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 10 Apr 2020 11:41:40 -0500
From:   Rob Herring <robh@kernel.org>
To:     Rajat Jain <rajatja@google.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>, dtor@google.com,
        Mark Rutland <mark.rutland@arm.com>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Enrico Weigelt <info@metux.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Allison Randal <allison@lohutok.net>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Stephen Boyd <swboyd@chromium.org>,
        linux-input@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, furquan@google.com,
        dlaurie@google.com, bleung@google.com, zentaro@google.com,
        dbehr@google.com, rajatxjain@gmail.com
Subject: Re: [PATCH v4 3/5] dt-bindings: input/atkbd.txt: Add binding for
 "function-row-physmap"
Message-ID: <20200410164140.GA25924@bogus>
References: <20200328185916.98423-1-rajatja@google.com>
 <20200328185916.98423-3-rajatja@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200328185916.98423-3-rajatja@google.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Mar 28, 2020 at 11:59:14AM -0700, Rajat Jain wrote:
> Create the documentation for the new introduced property, that
> describes the function-row keys physical positions.
> 
> Signed-off-by: Rajat Jain <rajatja@google.com>
> ---
> v4: Same as v3
> v3: same as v2
> v2: Remove the Change-Id from the commit log
> 
>  .../devicetree/bindings/input/atkbd.txt       | 34 +++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/atkbd.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/atkbd.txt b/Documentation/devicetree/bindings/input/atkbd.txt
> new file mode 100644
> index 0000000000000..816653eb8e98d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/atkbd.txt
> @@ -0,0 +1,34 @@
> +Device tree bindings for AT / PS2 keyboard device
> +
> +Optional properties:
> +
> +	function-row-physmap:
> +			An ordered array of the physical codes for the function
> +			row keys. Arranged in order from left to right.

A single optional property doesn't constitute a DT binding.

> +
> +Example:
> +
> +	This is a sample ACPI _DSD node describing the property:

Neither does this ACPI stuff.

Rob