Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp900164ybb; Fri, 10 Apr 2020 12:24:06 -0700 (PDT) X-Google-Smtp-Source: APiQypJVKK4IvOMKAeeB6AnwHdro7hXTWxLOXrhuJUOmFPitXVGhUhKOOYT7dP0lGOI4W/6V5R87 X-Received: by 2002:a0c:fdc2:: with SMTP id g2mr6279541qvs.59.1586546646695; Fri, 10 Apr 2020 12:24:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586546646; cv=none; d=google.com; s=arc-20160816; b=eX1JplKHQitAiStlYA/VbUPuWT4IBNNlDigUQ9t/5qxc0DoUlimKB4GGTHeto7p0/a CF2p7FMbtzjJTATbuhcxCM2GtapLIzcmpOJpT6wopuVoMNOkFSIP8rN/kMwwrKimGgIx KWCz+8+bV2iMuaX2yuDnc9F7G76wXPPnhy3zqyNg3noPp3TQc34YvpVTa+B/WRkCbFTp e/5jb9O164UjWbH6Jf+RrMtimxbj5dAMb7fl+/sch5CRwbT0G62x62bDfsR+XvQqvGF8 s9Zj1cIaKhqZxVw/q2HTiexFkOZevA300KC1QeOsF2DUezloojb5sY0O5VFsufvMIL+8 GcUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3Ain2YpJOpcgXCSAAzptl3FuIautSubo4bshSvRDBEY=; b=LjKN88haIxWhv+ite5JuIDgE4ms0DzAuh/AWR37MUnVR4SZ3Tysg5whlEkq1VKUClS mU6bl/hhiJs0YBqNf05EmZBXwXSv+mz0g5xy8YeTwv6CACtCbLi5cFv3Ic8mtETkf2WG +q+1KSB9lSWDCUeU9JkX5ALIJhwiW26uRMllZa83ljPX4tgQebInio7/6N/m3bVrLzxI wWdmWsLu5x7z4venz0Vkn1evEmPHM7Wu1yz7+UwUorSLw/lM7hp3s7yqXziodXHlm5Vy wIdu2RYnkO7nJ91/ozsDqgmnnwzgIZUuoYMXe7rFEvHqhqSQGyk+QRkXPAzZ8u4tZq8Q XM2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o10si1775822qkh.196.2020.04.10.12.23.51; Fri, 10 Apr 2020 12:24:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726680AbgDJTXE (ORCPT + 99 others); Fri, 10 Apr 2020 15:23:04 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:48496 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbgDJTXE (ORCPT ); Fri, 10 Apr 2020 15:23:04 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jMzEq-0003Tq-Jq; Fri, 10 Apr 2020 19:22:52 +0000 From: Colin King To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Chris Wilson , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/i915/gt: remove redundant assignment to variable x Date: Fri, 10 Apr 2020 20:22:52 +0100 Message-Id: <20200410192252.76908-1-colin.king@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable x is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c index 3aa8a652c16d..0b597427bde9 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c @@ -1205,7 +1205,7 @@ static void print_request(struct drm_printer *m, { const char *name = rq->fence.ops->get_timeline_name(&rq->fence); char buf[80] = ""; - int x = 0; + int x; x = print_sched_attr(rq->i915, &rq->sched.attr, buf, x, sizeof(buf)); -- 2.25.1