Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v10 18/55] Input: atmel_mxt_ts: Rename mxt_hw_version_show
 to hw_version_show
To:     Jiada Wang <jiada_wang@mentor.com>, nick@shmanahar.org,
        dmitry.torokhov@gmail.com, jikos@kernel.org,
        benjamin.tissoires@redhat.com, bsz@semihalf.com
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        erosca@de.adit-jv.com, Andrew_Gabbasov@mentor.com
References: <20200331105051.58896-1-jiada_wang@mentor.com>
 <20200331105051.58896-19-jiada_wang@mentor.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <aae29974-7a8f-404b-b115-59416021ff61@gmail.com>
Date:   Sat, 11 Apr 2020 00:46:54 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200331105051.58896-19-jiada_wang@mentor.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

31.03.2020 13:50, Jiada Wang пишет:
> Rename mxt_hw_version_show to hw_version_show to address checkpatch warning
> 
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---
>  drivers/input/touchscreen/atmel_mxt_ts.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index b2a37a9597f3..cec823de4096 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -3114,8 +3114,8 @@ static ssize_t fw_version_show(struct device *dev,
>  }
>  
>  /* Hardware Version is returned as FamilyID.VariantID */
> -static ssize_t mxt_hw_version_show(struct device *dev,
> -				   struct device_attribute *attr, char *buf)
> +static ssize_t hw_version_show(struct device *dev,
> +			       struct device_attribute *attr, char *buf)
>  {
>  	struct mxt_data *data = dev_get_drvdata(dev);
>  	struct mxt_info *info = data->info;
> @@ -3404,7 +3404,7 @@ static const struct attribute_group mxt_fw_attr_group = {
>  };
>  
>  static DEVICE_ATTR_RO(fw_version);
> -static DEVICE_ATTR(hw_version, S_IRUGO, mxt_hw_version_show, NULL);
> +static DEVICE_ATTR_RO(hw_version);
>  static DEVICE_ATTR(object, S_IRUGO, mxt_object_show, NULL);

What about to add a patch to convert the mxt_object_show to
DEVICE_ATTR_RO(object_show)?