Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drm/hisilicon: Code refactoring for hibmc_drv_vdac
To:     Joe Perches <joe@perches.com>, Tian Tao <tiantao6@hisilicon.com>,
        <puck.chen@hisilicon.com>, <airlied@linux.ie>, <daniel@ffwll.ch>,
        <tzimmermann@suse.de>, <kraxel@redhat.com>,
        <alexander.deucher@amd.com>, <tglx@linutronix.de>,
        <dri-devel@lists.freedesktop.org>, <xinliang.liu@linaro.org>,
        <linux-kernel@vger.kernel.org>
CC:     <linuxarm@huawei.com>
References: <1586573387-42003-1-git-send-email-tiantao6@hisilicon.com>
 <78e966cacffbab8c43be6a02aa3f5af2478917d0.camel@perches.com>
From:   "tiantao (H)" <tiantao6@huawei.com>
Message-ID: <e2b9f9f1-693e-57bc-6b0b-a6a5f095be16@huawei.com>
Date:   Sat, 11 Apr 2020 14:12:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <78e966cacffbab8c43be6a02aa3f5af2478917d0.camel@perches.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Thank you, your suggestion is accepted and I will issue v2

?? 2020/4/11 11:43, Joe Perches д??:
> On Sat, 2020-04-11 at 10:49 +0800, Tian Tao wrote:
>> code refactoring for hibmc_drv_vdac.c, no actual function changes.
> 
> Seems sensible.
> 
>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> []
>> @@ -109,13 +83,6 @@ int hibmc_vdac_init(struct hibmc_drm_private *priv)
>>   	struct drm_connector *connector;
>>   	int ret;
>>   
>> -	connector = hibmc_connector_init(priv);
>> -	if (IS_ERR(connector)) {
>> -		DRM_ERROR("failed to create connector: %ld\n",
>> -			  PTR_ERR(connector));
>> -		return PTR_ERR(connector);
>> -	}
>> -
>>   	encoder = devm_kzalloc(dev->dev, sizeof(*encoder), GFP_KERNEL);
>>   	if (!encoder) {
>>   		DRM_ERROR("failed to alloc memory when init encoder\n");
> 
> The alloc error messages could be removed.
> 
>> @@ -131,6 +98,21 @@ int hibmc_vdac_init(struct hibmc_drm_private *priv)
>>   	}
>>   
>>   	drm_encoder_helper_add(encoder, &hibmc_encoder_helper_funcs);
>> +
>> +	connector = devm_kzalloc(dev->dev, sizeof(*connector), GFP_KERNEL);
>> +	if (!connector) {
>> +		DRM_ERROR("failed to alloc memory when init connector\n");
> 
> and here.
> 
> 
> 
> .
>