Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1430901ybb; Sat, 11 Apr 2020 03:17:49 -0700 (PDT) X-Google-Smtp-Source: APiQypIwUB01PXcN1MOF4cqvF9H1chpGDn4NOYGJjAi353QNPBOf3L8bIGGAnkhedGky85ZhlVHC X-Received: by 2002:ac8:346f:: with SMTP id v44mr2935750qtb.205.1586600269116; Sat, 11 Apr 2020 03:17:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586600269; cv=none; d=google.com; s=arc-20160816; b=VkajMjCtWXBYwD6NT4wIMyxUZ5Y2vU0Gw2xAcZ9UGxxlACPreCy+1vkVCdaqKuC1D1 /Vh9nNOVeuEy9qFB+vzQSd76gEchm+UhKcXSo2qdbRiL2n7+9EJDLqCyvwPwGkudXvYd ahGqqnKoB5r24iz7L99ZhF18Y2aPEXIZcNudl7pCb39Dc+kYY1yoeYIQLlM8L5MBzQEB Vw+Shk/ibbutDer6n/TRBO7afVCK3x3VC/7ECnSBsQ63rsrTu8g/sCdCl1Cacg8pLzs7 AdBzx2lh8UzbAoPP0hD3foc38jb131ntpkacR/HvB+blqrRmlPcaL7HMYlH3v1R0WNei tkEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=scubK+r04ANvJ29JphyW/4RuEQax/zyXuzaYQPzCFCM=; b=sI8hZUl/PZlRSVDOiNc2M0BRRByNrNV9A/6LX3O6vuj3BaaYaK7gHADaIGSdVI4WGM W5kwgfw+LkcuyjjAXRoxY7VOxim/9XP5muswQmiU0X71eVOTDkFmxwPD+nlRRy48AFzy Rx8Ny4i9BzcizbmDgqeDSi/phBOsTE/JKAlJSBEBdOKZB4wyLj2oE75uaQhc4B7pwYSq p1bRyDIKjoxbpKJ8cu/UJI009so3TIqTu2yMggbMwUeqjWXTKYGUOuRRjiOxUTYSTUa0 pZ+bXhGb/UN8AzOlJGSBNIsiu6jU6mhRSPoPU7+gUEolp6+Z8+s0eGyydqPjvLGLz2Z8 q4qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GNaRhQ9n; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i50si2589454qtc.349.2020.04.11.03.17.34; Sat, 11 Apr 2020 03:17:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GNaRhQ9n; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726182AbgDKKQA (ORCPT + 99 others); Sat, 11 Apr 2020 06:16:00 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44782 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbgDKKQA (ORCPT ); Sat, 11 Apr 2020 06:16:00 -0400 Received: by mail-pg1-f194.google.com with SMTP id n13so2062911pgp.11; Sat, 11 Apr 2020 03:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=scubK+r04ANvJ29JphyW/4RuEQax/zyXuzaYQPzCFCM=; b=GNaRhQ9nYhkAq0UI9ryUmQD01lO3Pku9cYd7QbjSFYzwMvPG1d+YJDoqUKlnvk7IzZ x9bZUR+RrVUlKk8vCjUP04j5VRT0hMHfzIC6ON9X/AIlPiaDIVEfqZ5Qq3w0gEPSf/Rg ozUvI420hMOdneTBRCsQTvemtvPrxsVUAs3L4rQ0IIuZUQuOGoSoEVL7Me24EuCtlT3Z IeVOO36F2l/VTog/B0fNq7Qekt1MczQ5iuivaNqH0H4r1kJ8YKBXAJbFXL2HL25V8f/z R3EdXokEF+FbRyfJV91LEuhtmU3XyM6Eu4qpfbdb52sKQX6l7YfsyAWsIR5N3CR5vm6p gQXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=scubK+r04ANvJ29JphyW/4RuEQax/zyXuzaYQPzCFCM=; b=RaOd+JlvVina3JNEgoB4cSkoG4oXNIzRdNKmvXJJu8wXkmWViIPclijBhyQKtkbmEZ AEBPa7NWo3LB+85iyF0DQyHJu2PBkUPwOPd3lRnR0iMhz+jZd8tw2pMws38ls+PIG1uL Q3umwHpScao4flAJGKHzQbvWmiloBXvgjiLyOn6byfFdEr9XJvz2WnAKnyYZotAvG/qe CW+Yx1E2U+IUE3ovwBJjzeTxGD/Cs6yj/4GfH2pUGRx17mAxCS1pIYEASasJg30PUe95 B0vd+XCrlB234J0ptgOyKdsTgnVEtBblzGsDy1vKf9QTiBVxMBmISZVspt1/cmiIvKFd UvUQ== X-Gm-Message-State: AGi0PuZ+RiGKYAaltPmg96AFjfPiSckPxDadIesxzB8Aj07n76N1zR8x SSJaqG+Bztjyxua9cFhD1c4pAslkKK6JgSZ/t20= X-Received: by 2002:aa7:9097:: with SMTP id i23mr9016213pfa.170.1586600159486; Sat, 11 Apr 2020 03:15:59 -0700 (PDT) MIME-Version: 1.0 References: <20200410201948.1293-1-sravanhome@gmail.com> <20200410201948.1293-5-sravanhome@gmail.com> In-Reply-To: <20200410201948.1293-5-sravanhome@gmail.com> From: Andy Shevchenko Date: Sat, 11 Apr 2020 13:15:47 +0300 Message-ID: Subject: Re: [PATCH v7 4/5] power: supply: Add support for mps mp2629 battery charger To: Saravanan Sekar Cc: Lee Jones , Rob Herring , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Sebastian Reichel , devicetree , Linux Kernel Mailing List , linux-iio , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 10, 2020 at 11:20 PM Saravanan Sekar wrote: > > The mp2629 provides switching-mode battery charge management for > single-cell Li-ion or Li-polymer battery. Driver supports the > access/control input source and battery charging parameters. ... > +static DEVICE_ATTR_RW(batt_impedance_compensation); > + > +static struct attribute *mp2629_charger_sysfs_attrs[] = { > + &dev_attr_batt_impedance_compensation.attr, > + NULL > +}; > +ATTRIBUTE_GROUPS(mp2629_charger_sysfs); Did I miss ABI documentation? -- With Best Regards, Andy Shevchenko