Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <8d097283a4676f7e1050c9d6664d89d710e21bcf.camel@perches.com>
Subject: Re: [PATCH] taging: android: ashmem: Declared const key
From:   Joe Perches <joe@perches.com>
To:     MugilRaj <dmugil2000@gmail.com>
Cc:     mugil2301 <110117057@nitt.edu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Christian Brauner <christian@brauner.io>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date:   Sat, 11 Apr 2020 12:41:26 -0700
In-Reply-To: <1586633396-24237-1-git-send-email-dmugil2000@gmail.com>
References: <1586633396-24237-1-git-send-email-dmugil2000@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.34.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 2020-04-12 at 00:59 +0530, MugilRaj wrote:
> From: mugil2301 <110117057@nitt.edu>

You need to verify the patch subject.
You need a change log message too.

> Signed-off-by: mugil2301 <110117057@nitt.edu>

You need to put your legal name here

> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
[]
> @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>  
>  static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
>  {
> -	static struct file_operations vmfile_fops;
> +	static const  struct file_operations vmfile_fops;
>  	struct ashmem_area *asma = file->private_data;
>  	int ret = 0;

(this won't compile)

checkpatch is not always right.

Do please compile the files changed by your patch
and verify change correctness before sending any
proposed patch.