Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2295465ybb; Sun, 12 Apr 2020 02:27:14 -0700 (PDT) X-Google-Smtp-Source: APiQypISDSJso+15UBGH6yyUnHnrgB6KdP+/WcLK3HeNdXAk72ekGu9/bOYOUzv7ViG5B9S30qAD X-Received: by 2002:a37:6117:: with SMTP id v23mr8535565qkb.100.1586683634321; Sun, 12 Apr 2020 02:27:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586683634; cv=none; d=google.com; s=arc-20160816; b=Ci6g6w0nHDbCBrBw5oFXg91vBez7TfEPFGQVi2I0TiGj/czXo7OXdpYgJRP1TYTifL gxct7cAeWkx0neOwJKOkXLB6DRmPxyqfGapXv/ee3iOtrp+6/eQCisXVHY3sulhgutHD dV6Im6ySU4Fd84KVpmacfnV+fMBP3GaYAzu5+XdOpAd0MN8CFF7vZLHd7VEMU7er3yfx Op2I8ZrAGQrjmOgycJt7jN/zoXCocMIDOgudJcrQJo4JTEMLq/39k+WlEAHb+YxO+C+x Yvi4mgiCDMZEbxRzsZwJxmJU+MvS0ZVnPZeiZSD17Pp72S2W+UvPW2mvYmHazd45Xthf ImDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Cz6/j8+S9WuNch5KLTGrgDqlM8mH7Xz1lzotq8TImkw=; b=HdQc+rWe3ugfo5wgStPW2x2RWINI43tv/DUKaxAeDD+K9xoNjR5PGawPrXJFn6P+Yy UJfqCk4zh4VvsoRwlAjoxr3iqcEHis17/tfi80Y/QBLzOvJAvN6y8NqG+ulGaddaF0D4 PfVIqoN/jJ5ydTsNXzB88FG+9DyVNeOsVdiBDVelmdfLLdv4ysBb5baWjch2XNZlEV3M C1Wp1zHIcHO+ZGUeKcltjcq2fQCZUlQibrpNfjd36mCUb49Dc8X/7i54jBxAzf6yjtNF Ghsl6e06iql+60NyOEKGfCA1lsm4zfd77rF9sLYKTxd9gqtSBjEoTMI8voGeiZ5HWTMj iXcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z67si4281226qkb.64.2020.04.12.02.27.00; Sun, 12 Apr 2020 02:27:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726896AbgDLJ0N (ORCPT + 99 others); Sun, 12 Apr 2020 05:26:13 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:3994 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbgDLJ0N (ORCPT ); Sun, 12 Apr 2020 05:26:13 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.19]) by rmmx-syy-dmz-app05-12005 (RichMail) with SMTP id 2ee55e92de9da03-1fbc8; Sun, 12 Apr 2020 17:25:51 +0800 (CST) X-RM-TRANSID: 2ee55e92de9da03-1fbc8 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.1.172.56]) by rmsmtp-syy-appsvr10-12010 (RichMail) with SMTP id 2eea5e92de9c9bf-68f8a; Sun, 12 Apr 2020 17:25:51 +0800 (CST) X-RM-TRANSID: 2eea5e92de9c9bf-68f8a From: Tang Bin To: khalasa@piap.pl, davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin , Shengju Zhang Subject: [PATCH] net: ethernet: ixp4xx: Add error handling in ixp4xx_eth_probe() Date: Sun, 12 Apr 2020 17:27:28 +0800 Message-Id: <20200412092728.8396-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function ixp4xx_eth_probe() does not perform sufficient error checking after executing devm_ioremap_resource(),which can result in crashes if a critical error path is encountered. Signed-off-by: Tang Bin Signed-off-by: Shengju Zhang --- drivers/net/ethernet/xscale/ixp4xx_eth.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c index 269596c15..2e5202923 100644 --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c @@ -1387,6 +1387,8 @@ static int ixp4xx_eth_probe(struct platform_device *pdev) return -ENODEV; regs_phys = res->start; port->regs = devm_ioremap_resource(dev, res); + if (IS_ERR(port->regs)) + return PTR_ERR(port->regs); switch (port->id) { case IXP4XX_ETH_NPEA: -- 2.20.1.windows.1