Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750737AbWB1EQo (ORCPT ); Mon, 27 Feb 2006 23:16:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750768AbWB1EQn (ORCPT ); Mon, 27 Feb 2006 23:16:43 -0500 Received: from rtr.ca ([64.26.128.89]:32168 "EHLO mail.rtr.ca") by vger.kernel.org with ESMTP id S1750737AbWB1EQn (ORCPT ); Mon, 27 Feb 2006 23:16:43 -0500 Message-ID: <4403CEA9.4080603@rtr.ca> Date: Mon, 27 Feb 2006 23:16:41 -0500 From: Mark Lord User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060130 SeaMonkey/1.0 MIME-Version: 1.0 To: Tejun Heo , David Greaves Cc: Mark Lord , Jeff Garzik , Justin Piszcz , linux-kernel@vger.kernel.org, IDE/ATA development list , albertcc@tw.ibm.com, axboe@suse.de, Linus Torvalds Subject: Re: LibPATA code issues / 2.6.15.4 References: <43F2050B.8020006@dgreaves.com> <200602141300.37118.lkml@rtr.ca> <440040B4.8030808@dgreaves.com> <440083B4.3030307@rtr.ca> <4400A1BF.7020109@rtr.ca> <4400B439.8050202@dgreaves.com> <4401122A.3010908@rtr.ca> <44017B4B.3030900@dgreaves.com> <4401B560.40702@rtr.ca> <4403704E.4090109@rtr.ca> <4403A84C.6010804@gmail.com> In-Reply-To: <4403A84C.6010804@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 29 Tejun Heo wrote: .. >> These may be unsafe in general, unless we tag controllers as >> FUA-capable and NON-FUA-capable, in addition to tagging the drives. > > All sii controllers and piix/ahci seem to handle FUA pretty ok. And > yeah, we may have to create controller blacklist too. Or maybe a whitelist instead, since nearly all existing hardware pre-dates FUA commands. Or maybe just have a libata function to test whether the FUA commands actually work or not, before enabling them for general use. *That* could be a much better approach, given the large number of possible drive/controller combos, and it cuts down on the maintenance headache of having to list everything on a list somewhere. > BTW, can you let me know what drive we're talking about now (model name > and firmware revision)? David: we need to see the output from "hdparm --Istdout /dev/sda (or whichever drive it was that was failing on your system). Cheers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/