Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: iq0G3H6TTZ2qbTBDcjKoJE4FgnSnKWPrxFHtt5vh7NzzBAhGVkKFngeWSYigp+Jr7qcX7P6yzK
 gLCH48Vux04A==
IronPort-SDR: BnEmlzSQ0yaLFn713ppG64HJ3Tn8i35NOeDaqWcY6rLMjAKliBwnLtoYKCiIk4UQPl9SRnfuGU
 8+HtasicDgPw==
Date:   Sun, 12 Apr 2020 17:18:02 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Shuah Khan <shuah@kernel.org>
Cc:     linux-kselftest@vger.kernel.org, linux-integrity@vger.kernel.org,
        Nikita Sobolev <Nikita.Sobolev@synopsys.com>,
        Tadeusz Struk <tadeusz.struk@intel.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/tpm: Fix runtime error
Message-ID: <20200412141802.GA70976@linux.intel.com>
References: <20200412141118.70688-1-jarkko.sakkinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200412141118.70688-1-jarkko.sakkinen@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Apr 12, 2020 at 05:11:17PM +0300, Jarkko Sakkinen wrote:
> There is some random clutter in test_smoke.sh:
> 
>   ./test_smoke.sh: line 3: self.flags: command not found
> 
> Remove it.
> 
> Fixes: b32694cd0724 ("Kernel selftests: tpm2: check for tpm support")
> Cc: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Instead we should apply a revert to the original patch and Nikita could
refine it. Have additional questions e.g. why the constant is declared
instead of just exit 4? The commit message long description also fails
to document any sane reasoning for anything.

It is not enough to response the reasoning to me here. It needs to be
in the commit log. This is terrible.

It is obvious there has not been any kind of sane review process in
place.

/Jarkko