Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2542454ybb; Sun, 12 Apr 2020 08:32:34 -0700 (PDT) X-Google-Smtp-Source: APiQypINYp4c+Y/mo2UJnCepWuKcpBmOp5FgU92ayKSNYB3Cw8yvLaBYDzrlW2si1WdhG0XrSaDE X-Received: by 2002:ac8:22ad:: with SMTP id f42mr7616935qta.292.1586705554406; Sun, 12 Apr 2020 08:32:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586705554; cv=none; d=google.com; s=arc-20160816; b=TxYIoLdT3jIP3z8DTH1Dg+8niwMYzGXwjOPlO62UIbNe++FT0ssnmFwESko0K4YTX9 ShPZY8ljpy3PSfJDcN/udnth9FkITiDi2QrbH4gNpKrF7fBilJXR/4wCQqvQ0IsJu7Hw nDlKECau7yTI6Ol7IFt4DCvat64pxrZLbh76XbgawYTg/H7DKsL6pHThINJfgX1fqI/Y HQjsY1JgcFxHK5+wn7mfF7U4Xvrj9DF/915LfMxp1K5zI14wDZ9uJFnVTRzKDWLboSHY VI7u1q6P6YRVsLgAkxYXZWDEObU8A8FJBlHCAK/XmGX9hEKQUETUrd1SIbpWNOCmuvMT yOjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=RTj0VEX5TNqzrqwsQNvi0lYaU3YprHALdXBJBp1u/JI=; b=xv/Xt8U+I7gcnAysxqtX8fS6uY71AvlrbWCF5Omz8LrRMXqnzyB2F5GLb5Ai4iGrQY HtXyp6/syrg+ZsixSogrlf9erH899wcR5xStiSz9UDbR/jOmeQqKtOQd0kTakqUTjFMG YHahnrI7FnRteW8A2bF7IYSJkix9kp50/kLIEbfIb7pAxHlXpjLomLDNYYMdnH5eNR6H 6OgorzxmbmUocSr5L7BMgI18+lps8shmyXLcc99PZvYL/+uqoe141Fgtxlilnej0f09U hYPcysRMdUam/i2vwIuWKNsWI6V2i+G4Umfxgt4yMQBQ1xxkRdtV35IvqZwS+cFgBSOt JtCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="O5Ue/2t4"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 8si4752288qkv.341.2020.04.12.08.31.49; Sun, 12 Apr 2020 08:32:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="O5Ue/2t4"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727015AbgDLPaF (ORCPT + 99 others); Sun, 12 Apr 2020 11:30:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.18]:42602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgDLPaF (ORCPT ); Sun, 12 Apr 2020 11:30:05 -0400 X-Greylist: delayed 397 seconds by postgrey-1.27 at vger.kernel.org; Sun, 12 Apr 2020 11:30:05 EDT Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE2FC02A1AD for ; Sun, 12 Apr 2020 08:23:24 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id h11so2537687plr.11 for ; Sun, 12 Apr 2020 08:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=RTj0VEX5TNqzrqwsQNvi0lYaU3YprHALdXBJBp1u/JI=; b=O5Ue/2t4RngZU62hTmQrNo88logu66R+UrpS1WoZBldh2oQE18EqtWNa5URxBY9F6b ttLZvyNe+Sedp8nK8f2ytarB/uAtDiKbO5jZ5CZuODbxP532IQlYl5twFsnA7n5qhrBQ GxYxBRr67aHmShmrmuyImH67C1swvFPkRqpwQcy5Tmu35pt9AbHOfw6syTaGpW4WBqmM T0wQAobQY2U+48OxHck2YqCcZQ4r+1uA+g4NqzvcbMuH/fpdx4bGGSlFSrL9YED9IRpi Ppr5+D3+IOhtVGzdC08j0yWYdWOab0tVdy8dB2zjoAhYVkydt7aH3VlCsKmbXeNTVBTS Gt3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RTj0VEX5TNqzrqwsQNvi0lYaU3YprHALdXBJBp1u/JI=; b=i0L/fF0pWIovP8kNdNhnvn0SXkqnr47O2nbjZPHx1vwxnp+HRROs6med1mNi97FCVH OWRaA36LqsXkpG/SFi5ah3D1APIEqlhzh+9lZq1CZVubyCQC/+eraD1tm3xUwG6wccxK 2GrykjlPPik5R1OaHoXddvSEtq/7trBvFBnZK4AuBVUtBRpyefe//MiH63M4Hd6Wc0pa cmCbhMDr3iGwXMeYKJk8svaktr+IjtyywOG0zWNQUGPZxZ+NCQCmnIXj3SB8FMB90dz1 K3ycsIeoPVZDzF/9DK2bJvAA6v6Mf9BxwdU6sepsUKrdo1peXYrBLmu3/4LJ/Mc/4RgQ cptA== X-Gm-Message-State: AGi0PuZfuZ7Tkqjtuqf0plUAULvkDZbKDzWirkatWYMbWpiwV+iIPKch dljMQtZmf21ZYDAwCsJWoPRiNi+iyVNM7g== X-Received: by 2002:a17:90a:3343:: with SMTP id m61mr17721046pjb.112.1586705001312; Sun, 12 Apr 2020 08:23:21 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id n21sm6152771pgf.36.2020.04.12.08.23.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Apr 2020 08:23:20 -0700 (PDT) Subject: Re: [PATCH 0/5] submission path refactoring pt.2 To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <774f0f44-d6d8-6a5a-4808-090f69781e4c@kernel.dk> Date: Sun, 12 Apr 2020 09:23:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/11/20 5:05 PM, Pavel Begunkov wrote: > The 2nd and last part of submission path refactoring. This moves > request initialisation bits into io_init_req(), doing better job > logically segmenting the code. Keeping negative diffstat as a bonus. > > Pavel Begunkov (5): > io_uring: remove obsolete @mm_fault > io_uring: track mm through current->mm > io_uring: DRY early submission req fail code > io_uring: keep all sqe->flags in req->flags > io_uring: move all request init code in one place > > fs/io_uring.c | 196 +++++++++++++++++++++++--------------------------- > 1 file changed, 90 insertions(+), 106 deletions(-) Looks good, applied. Thanks! -- Jens Axboe