Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3014041ybb;
        Sun, 12 Apr 2020 21:34:43 -0700 (PDT)
X-Google-Smtp-Source: APiQypI0htW8hgyInMyRkVQ+7bqvx2/56XBBIkqyhbB3k8VpqyRPuhEStTMXlJaNPmYX974eyXxW
X-Received: by 2002:a37:5a02:: with SMTP id o2mr14492658qkb.380.1586752483620;
        Sun, 12 Apr 2020 21:34:43 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1586752483; cv=none;
        d=google.com; s=arc-20160816;
        b=hu+JJ07UdiMv7jFoWEeiB21e6lQFQe7+RksS4Fucjpjv2AWppEG3soqiiHTR5CYOX5
         GW81qJlA7DGcJZu/CmYxuXO8aMIgM/kAMFruEPYuVReLS0TsbnttVM6Satd+esICpDpy
         iYrs/vuuBogeGhyB+847RraTzQHatzI/mFQWRV5Up91d+87X23r3Zsl2kERD4bZ2fG5V
         5nPznPE/XsWvMJUVSEbYxFXh+7hy1X/28TwDzK50Ueuu1IR+Zj+9AWslFR02fg8jlQbG
         rIEPo4mH3wc8s2xfOU9YEIbDZwyeJz4uLmfEYdLeVlhqYqFUISbCGoFMClSLSb+FPuRL
         ewFQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=Vt8Ld9zuEmSCYLrKFUMhe6BDV5l8zhpsDhM4MlbxVDU=;
        b=HOjn9aovtYJOFBd4j2klQBYrOCML1woRkCWonHxjMwEAO1veHBpO91GMKOexuf7tiO
         hmRtd0ud6lseNx83iww0Dk3vihWC7Hy0ifXLwtdeiKr50/P7upirExQI0bn3ppsDsYb3
         YqTUti3bdRSQjBEmYvnU5uJojiubeh1Dq++V4g7BPi3nS4jBEw9lyKPtOeXM84//hvwD
         Rv9XIpsMTNdmMA90lksH+219f40k2tKa9pIxJ5ZeAQRZP/UaMi/aES60OiMaGFxVIiEd
         6trs4Hs35Sr663CdqcKzpNSsfmvRL94OUgG11tniQy9VwAYnw0RECaGgLFXIuwQXx6Gx
         SOFQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=UIalYcu8;
       spf=neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-kernel-owner@vger.kernel.org) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org ([209.132.180.67])
        by mx.google.com with ESMTP id i17si5282259qkl.246.2020.04.12.21.34.27;
        Sun, 12 Apr 2020 21:34:43 -0700 (PDT)
Received-SPF: neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-kernel-owner@vger.kernel.org) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=UIalYcu8;
       spf=neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-kernel-owner@vger.kernel.org) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727637AbgDLSfk (ORCPT <rfc822;mailist1go@gmail.com>
        + 99 others); Sun, 12 Apr 2020 14:35:40 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.18]:44880 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727329AbgDLSfk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 12 Apr 2020 14:35:40 -0400
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52DC3C0A3BF0;
        Sun, 12 Apr 2020 11:35:40 -0700 (PDT)
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (c-67-180-217-166.hsd1.ca.comcast.net [67.180.217.166])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 8F1F320692;
        Sun, 12 Apr 2020 18:35:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1586716540;
        bh=3/wGsfbfYY5CVO1/2e2j77ki+CMc/twF4oRNiRbEzgw=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=UIalYcu8ewiz/BxpdRnR86ChTIsMg79miPvh9DuiBixYAQdWQB8kwSILVCHa+ZHp/
         +NSKUp3LGhMtGn9pBNI0lXUr5uqisW+0S81i+cEYss2P30iUEINYK/Tduo6XSbRFMp
         GFnUOTIGXPdwgXSarYFLtJjw9BsRgj1sPRhkZQGk=
Date:   Sun, 12 Apr 2020 11:35:38 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Tang Bin <tangbin@cmss.chinamobile.com>
Cc:     khalasa@piap.pl, davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] net: ethernet: ixp4xx: Add error handling in
 ixp4xx_eth_probe()
Message-ID: <20200412113538.517669d9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200412092728.8396-1-tangbin@cmss.chinamobile.com>
References: <20200412092728.8396-1-tangbin@cmss.chinamobile.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 12 Apr 2020 17:27:28 +0800 Tang Bin wrote:
> The function ixp4xx_eth_probe() does not perform sufficient error
> checking after executing devm_ioremap_resource(),which can result
> in crashes if a critical error path is encountered.
> 
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>

Please provide an appropriate Fixes: tag.