Received-SPF: neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-kernel-owner@vger.kernel.org) client-ip=209.132.180.67;
Date:   Sun, 12 Apr 2020 13:27:14 -0700
From:   Josh Triplett <josh@joshtriplett.org>
To:     "Jubran, Samih" <sameehj@amazon.com>
Cc:     "Machulsky, Zorik" <zorik@amazon.com>,
        "Belgazal, Netanel" <netanel@amazon.com>,
        "Kiyanovski, Arthur" <akiyano@amazon.com>,
        "Tzalik, Guy" <gtzalik@amazon.com>,
        "Bshara, Saeed" <saeedb@amazon.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH] ena: Speed up initialization 90x by reducing poll
 delays
Message-ID: <20200412202714.GB3916@localhost>
References: <eb427583ff2444dcae18e1e37fb27918@EX13D11EUB003.ant.amazon.com>
 <20200313122824.GA1389@localhost>
 <1679d519016c4984b67eeb510d50e4b4@EX13D11EUB003.ant.amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1679d519016c4984b67eeb510d50e4b4@EX13D11EUB003.ant.amazon.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Apr 12, 2020 at 09:37:22AM +0000, Jubran, Samih wrote:
> I wanted to let you know that we are still looking into your patch. 
> After some careful considerations we have decided to set the value of 
> ENA_POLL_US to 100us. The rationale behind this choice is that the 
> device might take up to 1ms to complete the reset operation and we 
> don't want to bombard device. We do agree with most of your patch 
> and we will be sending one based on it for review.

Thank you, that sounds entirely reasonable.

Please also consider making the probing asynchronous (via linux/async.h)
to allow other initialization to happen in parallel.