Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3051771ybb; Sun, 12 Apr 2020 22:43:37 -0700 (PDT) X-Google-Smtp-Source: APiQypLk++0qRX9pZIl1Lm092gLLPnlp5U0kD8lOZjtqotAVSx3aLUmPrF/5tr0bRGKZ3Wcxp+a6 X-Received: by 2002:a37:8cc1:: with SMTP id o184mr14378632qkd.187.1586756617628; Sun, 12 Apr 2020 22:43:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586756617; cv=none; d=google.com; s=arc-20160816; b=bzZysK4SCbt1/ll0YnV/KcIvd0438YoOXYGsLRdKy9iI9kAnTlZOqf7WkyxBe0b9H7 U0yL8vLgE1K2WqcprELCJCiF/2Jpag0hLJCXvbgPW0zR8U4lu3AZozhD2Q8cgaPpfNlE DIOjDPChbog05A9nuch0gxgbkmtHzesGrWQPOdQTng+gYytdiFzIsc4VqQ+kydYROqKS rh20bHw8yZ40gIg+NzVzWJlTqBL0e0AMsVAuPrFJ9C5XOgaeKYb4FCJSgc9cEmBjXeze Nk0DMiVfl/PGZ/gamKeGzhTPnIuj+6wWh0n8ORgB5U1v3r4idJ9mqERChxuGB1N8waJO g0/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=LM6KNQrZfwP8qE+Xfz/fZLqq5JV3FwqwRFpWn2E0vq0=; b=ZWUDvo1VVZjE5uQEuPh/0qpdv8ZwcIiM53ClBFMfky+7g19pKMhix5XGdNT7oHStWL tgUUtHdFmliJOGR8/ewPp+Ra9mvxwQYQVGFzrR5p6XXQ0GAi7WtQ9pf+yg+6f/SICd0H xGWFDnqruA/AWL43mkt7BvdoApoIh/0d12fp21e/phUZeXxV96uz5Xg5gE0s0JBLB8pa gfQMjkOJzebzHMsIBJrZcaIuCmI9548xMbR9P2/bXR1Nb5bwcpYL6iLxqu9oMCIXHQLC VaIT/PwQh+U/yH8fjGL+TaHBw+pd/5bvmbLnJLW9FwMt2qh5P5qzBWgH0/YB+31VYpZS 0Vkg== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-kernel-owner@vger.kernel.org) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org ([209.132.180.67]) by mx.google.com with ESMTP id c40si5081693qtk.317.2020.04.12.22.43.23; Sun, 12 Apr 2020 22:43:37 -0700 (PDT) Received-SPF: neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-kernel-owner@vger.kernel.org) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-kernel-owner@vger.kernel.org) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728201AbgDLU7n (ORCPT + 99 others); Sun, 12 Apr 2020 16:59:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.18]:42362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728180AbgDLU7n (ORCPT ); Sun, 12 Apr 2020 16:59:43 -0400 Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DC7FC0A3BF5 for ; Sun, 12 Apr 2020 13:59:43 -0700 (PDT) Received: from ip5f5bd698.dynamic.kabel-deutschland.de ([95.91.214.152] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jNjhN-0004xc-Qh; Sun, 12 Apr 2020 20:59:25 +0000 Date: Sun, 12 Apr 2020 22:59:23 +0200 From: Christian Brauner To: Zhiqiang Liu Cc: ebiederm@xmission.com, oleg@redhat.com, tj@kernel.org, guro@fb.com, joel@joelfernandes.org, jannh@google.com, "linux-kernel@vger.kernel.org" , Mingfangsen , Yanxiaodan , linfeilong Subject: Re: [PATCH] signal: check sig before setting info in kill_pid_usb_asyncio Message-ID: <20200412205923.a63kxtlqrczhyjwf@wittgenstein> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2020 at 10:18:33AM +0800, Zhiqiang Liu wrote: > > In kill_pid_usb_asyncio, if signal is not valid, we do not need to > set info struct. > > Signed-off-by: Zhiqiang Liu > Acked-by: Christian Brauner Applied, thanks! Christian