Received-SPF: neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-kernel-owner@vger.kernel.org) client-ip=209.132.180.67;
From:   "Quan, Evan" <Evan.Quan@amd.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        "Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "Zhang, Hawking" <Hawking.Zhang@amd.com>,
        "Grodzovsky, Andrey" <Andrey.Grodzovsky@amd.com>,
        "Liu, Monk" <Monk.Liu@amd.com>,
        "Russell, Kent" <Kent.Russell@amd.com>, "Ma, Le" <Le.Ma@amd.com>
CC:     "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] drm/amdgpu: Add missing '\n' in log messages
Thread-Topic: [PATCH] drm/amdgpu: Add missing '\n' in log messages
Thread-Index: AQHWEAoQdASoACOpX0iyhRsgnE8QdKh2XEiA
Date:   Mon, 13 Apr 2020 02:50:08 +0000
Message-ID: <DM6PR12MB26190847ADE19FC3BC5BBD56E4DD0@DM6PR12MB2619.namprd12.prod.outlook.com>
References: <20200411140356.28211-1-christophe.jaillet@wanadoo.fr>
In-Reply-To: <20200411140356.28211-1-christophe.jaillet@wanadoo.fr>
Accept-Language: en-US, zh-CN
Content-Language: en-US
msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ActionId=2c42595f-1e44-4d72-a3f0-00002f97f841;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=0;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=true;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal
 Use Only -
 Unrestricted;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2020-04-13T02:49:42Z;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=Evan.Quan@amd.com; 
x-originating-ip: [180.167.199.189]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: a4ba2bde-aeca-4796-38ed-08d7df55611d
x-ms-traffictypediagnostic: DM6PR12MB3915:|DM6PR12MB3915:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM6PR12MB3915B58C6479831090EB4F3BE4DD0@DM6PR12MB3915.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:619;
x-forefront-prvs: 037291602B
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2619.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(136003)(366004)(396003)(39860400002)(346002)(76116006)(316002)(6636002)(6506007)(26005)(86362001)(64756008)(66446008)(478600001)(66556008)(81156014)(66946007)(53546011)(4326008)(110136005)(33656002)(8676002)(71200400001)(8936002)(7696005)(186003)(15650500001)(54906003)(66476007)(9686003)(5660300002)(2906002)(52536014)(55016002)(921003)(21314003)(1121003);DIR:OUT;SFP:1101;
received-spf: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 6MOFRRZzYGuUkNsFy46ictYesbxAYFLebIoZTVT5zNVZVQNPC+KPZfCjhHMt09U1Mk3oHFGjOSmmLBUKkGUGhY8IngYYr8TI3q3HC5U7gihGg3GDU8Enq3R1o5RwzFBSDjntxWjEByzh+YfOEO2kZRvxbtoHHYmb8+kwt2OCdS349vgeF6GSWpRh+FfJqe0uaxYHvfO7VYo07WKeuHBajkxFaTarOpOCInmC+C4jqU3iVBq5t9TSamYxT0CMKmrmy824ochUWcsbAoVOYaryrHeK72oGohueWt1x3E4XTuRmkwFqR81QqNpaF0z53ih/9xDPRE1/dST6L6sBn6XH3udiQpiV5AV258YVminRe1me2AoCyTXvyrPso6DUohQ3RNi5TLcxZcPZUMaS79nzCGt0TZLF3nmwq0U7MwOs9lUWCiArPdyYpbgxABvYm7H86c5va+mtjPwqKFpV0nmSBKrP69J1i0Jf22GXBso8TQwNRPeBMTOGVxR2VHxgG20vcz93oQuDL2ztjag8nJJQfg==
x-ms-exchange-antispam-messagedata: AKbkIEBHTy1KNg8QhMJ0/b7Lbt0657TrSUk35v6FMBPtQvE6SXKSIE4AWn0MZ2/V7LL1zdQXpslZh42yaiBOKBSboV62HqoqwuBGoFbTkvLdJQF0nH6NahVjzG5SK1R5lZn4w+qttIRHNZfinr7czQ==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4ba2bde-aeca-4796-38ed-08d7df55611d
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2020 02:50:08.9590
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fhqJj1T+d7TOTp3VzoBeVe4XDDehkCrqwbnFBuJTAklGe0y95JBlrqrFzJVCcY3g
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3915
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Evan Quan <evan.quan@amd.com>

-----Original Message-----
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>=20
Sent: Saturday, April 11, 2020 10:04 PM
To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Chri=
stian.Koenig@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com>; airlied=
@linux.ie; daniel@ffwll.ch; Zhang, Hawking <Hawking.Zhang@amd.com>; Quan, E=
van <Evan.Quan@amd.com>; Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com>; Li=
u, Monk <Monk.Liu@amd.com>; Russell, Kent <Kent.Russell@amd.com>; Ma, Le <L=
e.Ma@amd.com>
Cc: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-k=
ernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe JAILLET =
<christophe.jaillet@wanadoo.fr>
Subject: [PATCH] drm/amdgpu: Add missing '\n' in log messages

Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.

While at it, split some long lines that where not that far.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Most of them have been added in commit bd607166af7f ("drm/amdgpu: Enable re=
ading FRU chip via I2C v3")
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/a=
md/amdgpu/amdgpu_device.c
index 87f7c129c8ce..3d0a50e8c36b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3249,25 +3249,25 @@ int amdgpu_device_init(struct amdgpu_device *adev,
=20
 	r =3D device_create_file(adev->dev, &dev_attr_pcie_replay_count);
 	if (r) {
-		dev_err(adev->dev, "Could not create pcie_replay_count");
+		dev_err(adev->dev, "Could not create pcie_replay_count\n");
 		return r;
 	}
=20
 	r =3D device_create_file(adev->dev, &dev_attr_product_name);
 	if (r) {
-		dev_err(adev->dev, "Could not create product_name");
+		dev_err(adev->dev, "Could not create product_name\n");
 		return r;
 	}
=20
 	r =3D device_create_file(adev->dev, &dev_attr_product_number);
 	if (r) {
-		dev_err(adev->dev, "Could not create product_number");
+		dev_err(adev->dev, "Could not create product_number\n");
 		return r;
 	}
=20
 	r =3D device_create_file(adev->dev, &dev_attr_serial_number);
 	if (r) {
-		dev_err(adev->dev, "Could not create serial_number");
+		dev_err(adev->dev, "Could not create serial_number\n");
 		return r;
 	}
=20
@@ -4270,7 +4270,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *a=
dev,
 		job_signaled =3D true;
=20
 	if (job_signaled) {
-		dev_info(adev->dev, "Guilty job already signaled, skipping HW reset");
+		dev_info(adev->dev, "Guilty job already signaled, skipping HW reset\n");
 		goto skip_hw_reset;
 	}
=20
@@ -4339,10 +4339,12 @@ int amdgpu_device_gpu_recover(struct amdgpu_device =
*adev,
=20
 		if (r) {
 			/* bad news, how to tell it to userspace ? */
-			dev_info(tmp_adev->dev, "GPU reset(%d) failed\n", atomic_read(&tmp_adev=
->gpu_reset_counter));
+			dev_info(tmp_adev->dev, "GPU reset(%d) failed\n",
+				 atomic_read(&tmp_adev->gpu_reset_counter));
 			amdgpu_vf_error_put(tmp_adev, AMDGIM_ERROR_VF_GPU_RESET_FAIL, 0, r);
 		} else {
-			dev_info(tmp_adev->dev, "GPU reset(%d) succeeded!\n", atomic_read(&tmp_=
adev->gpu_reset_counter));
+			dev_info(tmp_adev->dev, "GPU reset(%d) succeeded!\n",
+				 atomic_read(&tmp_adev->gpu_reset_counter));
 		}
 	}
=20
--=20
2.20.1