Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3065751ybb; Sun, 12 Apr 2020 23:07:11 -0700 (PDT) X-Google-Smtp-Source: APiQypI+H4chfRcpw1x90Q0LeDvBgAgvE13fnMzFJwo8PIBQClLm9LmWnKuf3L5fxm+7NWzShxlx X-Received: by 2002:a37:4648:: with SMTP id t69mr14163255qka.299.1586758030905; Sun, 12 Apr 2020 23:07:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586758030; cv=none; d=google.com; s=arc-20160816; b=is/MaXdY9p5Uu4Ii5GUoowwpMORxMTx7kvnKibaB7IuSwj56S/SlfoTnMZmzc4sL5A cDhlEsUh+W4pMhkkuqxvSoSXCUA4/71tDqEZv8Ru4pXYyBYtyJQPqHMvosBpeIEk1Py5 oF6g+Z68tCS1wUfVJO0OwGNGIUXS+i0Btz8uw954KZFI4BR4acEeahT36jfH/DRcGuUC ZvjTToLgh/8QgLyNoy6gajNGsBg23rcpeQ0SbSGY/ADS/mpleIgUUJIwTrF+/k5F54mk BXBrnN4h+xePQwpqzKzFlTD8tvJcifGuLdsmGNjJQwZA4v4USQ3OPfEQNEopRz9RixYP trFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:subject :from:cc:to; bh=/xhdPU2wtrs+gCcZbuCGF90sORAMJpnyXTAyMlsA5nQ=; b=Z9n/lgFk117EfxC8f7/KoQ/1Txp7iFulKMnyqr7nFM+YYEUv814ui0sBbtbL0Z2sFi iF9dbbaN936stVNXZ3YoAheULXSaytX17c4D9VJ9LuPZAC9SrEVUrEVDu1fyjsYwD1cn 4SBsUgbhN3HC6B2Pw3xomYnRLGSmI6/r4K/bfK3Fgssic/sYVa4CcSh6ZsLZJKx4KVcW MemWRz5YrcOZ8irNnbBHAqmv2rjUO7T4k8iPPuqV8o1vtDGoCDKVuQ0KnnKY9RSQwRZr 13frZ2MoZ8zLkAe9j5onIRE/gB0F6rAhv3gLsz0ACq5BbwptFWoUy33hbfB+gnq+j2WA aQ6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-kernel-owner@vger.kernel.org) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org ([209.132.180.67]) by mx.google.com with ESMTP id d17si1307142qvk.109.2020.04.12.23.06.57; Sun, 12 Apr 2020 23:07:10 -0700 (PDT) Received-SPF: neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-kernel-owner@vger.kernel.org) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.132.180.67 is neither permitted nor denied by best guess record for domain of linux-kernel-owner@vger.kernel.org) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726259AbgDMFvg (ORCPT + 99 others); Mon, 13 Apr 2020 01:51:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.18]:44456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbgDMFvg (ORCPT ); Mon, 13 Apr 2020 01:51:36 -0400 Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13FF7C008654; Sun, 12 Apr 2020 22:12:27 -0700 (PDT) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id B717B5D6576156E76FA3; Mon, 13 Apr 2020 13:12:22 +0800 (CST) Received: from [127.0.0.1] (10.173.220.183) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Mon, 13 Apr 2020 13:12:12 +0800 To: , , , "Jens Axboe" , "linux-kernel@vger.kernel.org" , CC: , , , linfeilong , Yanxiaodan , Mingfangsen , renxudong From: Zhiqiang Liu Subject: [PATCH] buffer: remove useless comment and WB_REASON_FREE_MORE_MEM, reason. Message-ID: <5844aa66-de1e-278b-5491-b7e6839640e9@huawei.com> Date: Mon, 13 Apr 2020 13:12:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.220.183] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhiqiang Liu free_more_memory func has been completely removed in commit bc48f001de12 ("buffer: eliminate the need to call free_more_memory() in __getblk_slow()") So comment and `WB_REASON_FREE_MORE_MEM` reason about free_more_memory are no longer needed. Signed-off-by: Zhiqiang Liu --- fs/buffer.c | 2 +- include/linux/backing-dev-defs.h | 1 - include/trace/events/writeback.h | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index b8d28370cfd7..07ab0405f3f5 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -973,7 +973,7 @@ grow_dev_page(struct block_device *bdev, sector_t block, struct page *page; struct buffer_head *bh; sector_t end_block; - int ret = 0; /* Will call free_more_memory() */ + int ret = 0; gfp_t gfp_mask; gfp_mask = mapping_gfp_constraint(inode->i_mapping, ~__GFP_FS) | gfp; diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h index 4fc87dee005a..ee577a83cfe6 100644 --- a/include/linux/backing-dev-defs.h +++ b/include/linux/backing-dev-defs.h @@ -54,7 +54,6 @@ enum wb_reason { WB_REASON_SYNC, WB_REASON_PERIODIC, WB_REASON_LAPTOP_TIMER, - WB_REASON_FREE_MORE_MEM, WB_REASON_FS_FREE_SPACE, /* * There is no bdi forker thread any more and works are done diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h index d94def25e4dc..85a33bea76f1 100644 --- a/include/trace/events/writeback.h +++ b/include/trace/events/writeback.h @@ -36,7 +36,6 @@ EM( WB_REASON_SYNC, "sync") \ EM( WB_REASON_PERIODIC, "periodic") \ EM( WB_REASON_LAPTOP_TIMER, "laptop_timer") \ - EM( WB_REASON_FREE_MORE_MEM, "free_more_memory") \ EM( WB_REASON_FS_FREE_SPACE, "fs_free_space") \ EMe(WB_REASON_FORKER_THREAD, "forker_thread") -- 2.19.1